From: Brian Starkey <Brian.Starkey@arm.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Vincent Donnefort <Vincent.Donnefort@arm.com>,
Sudipto Paul <Sudipto.Paul@arm.com>,
"Andrew F . Davis" <afd@ti.com>,
Christoph Hellwig <hch@infradead.org>,
Chenbo Feng <fengc@google.com>,
Alistair Strachan <astrachan@google.com>,
Hridya Valsaraju <hridya@google.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>
Subject: Re: [RESEND][PATCH v8 5/5] kselftests: Add dma-heap test
Date: Fri, 27 Sep 2019 09:20:20 +0000 [thread overview]
Message-ID: <20190927092017.zh2srpk3m4wxha4c@DESKTOP-E1NTVVP.localdomain> (raw)
In-Reply-To: <CALAqxLWyNiaf_Fxa76t9nA9Ea++O1Tcisq_XpH9e1yZJP1YujA@mail.gmail.com>
Hi John,
On Thu, Sep 26, 2019 at 02:36:33PM -0700, John Stultz wrote:
> On Mon, Sep 23, 2019 at 3:12 PM Brian Starkey <Brian.Starkey@arm.com> wrote:
> >
> > I didn't see any response about using the test harness. Did you decide
> > against it?
>
> Hey! Spent a little time looking at this bit and just wanted to reply
> to this point. So first, apologies, I think I missed the suggestion
> earlier. That said, now that I've looked a little bit at the test
> harness, and at least at this point it feels like it makes it harder
> to reason with than standard c code. Maybe I need to spend a bit more
> time on it, but I'm a little hesitant to swap over just yet.
>
> I'm not particularly passionate on this point, but are you? Or was
> this just a recommendation to check it out and consider it?
No particular strong feelings. I was just poking around the kernel
docs for testing and the only info there is about the test harness, so
wanted to check if you'd seen/considered it.
A quick grep of tools/testing shows that it's obviously not that
popular... so if you don't fancy it I won't complain.
Thanks,
-Brian
>
> thanks
> -john
next prev parent reply other threads:[~2019-09-27 9:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 18:47 [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION) John Stultz
2019-09-06 18:47 ` [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework John Stultz
2019-09-23 22:08 ` Brian Starkey
2019-09-24 17:10 ` John Stultz
2019-09-06 18:47 ` [RESEND][PATCH v8 2/5] dma-buf: heaps: Add heap helpers John Stultz
2019-09-23 22:08 ` Brian Starkey
2019-09-06 18:47 ` [RESEND][PATCH v8 3/5] dma-buf: heaps: Add system heap to dmabuf heaps John Stultz
2019-09-23 22:09 ` Brian Starkey
2019-09-06 18:47 ` [RESEND][PATCH v8 4/5] dma-buf: heaps: Add CMA " John Stultz
2019-09-23 22:10 ` Brian Starkey
2019-09-06 18:47 ` [RESEND][PATCH v8 5/5] kselftests: Add dma-heap test John Stultz
2019-09-23 22:11 ` Brian Starkey
2019-09-26 21:36 ` John Stultz
2019-09-27 9:20 ` Brian Starkey [this message]
2019-09-19 16:51 ` [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION) Sumit Semwal
2019-09-24 16:22 ` Ayan Halder
2019-09-24 16:28 ` John Stultz
2019-10-09 17:37 ` Ayan Halder
2019-10-09 18:27 ` Andrew F. Davis
2019-10-14 9:07 ` Brian Starkey
2019-10-16 17:40 ` Andrew F. Davis
2019-10-17 19:14 ` John Stultz
2019-10-17 19:29 ` Andrew F. Davis
2019-10-17 20:57 ` John Stultz
2019-10-18 9:55 ` Brian Starkey
2019-10-18 18:33 ` John Stultz
2019-10-18 18:41 ` Ayan Halder
2019-10-18 18:49 ` John Stultz
2019-10-18 18:57 ` Ayan Halder
2019-10-18 19:04 ` John Stultz
2019-10-19 13:41 ` Andrew F. Davis
2019-10-21 9:18 ` Brian Starkey
2019-10-22 13:51 ` Ayan Halder
2019-10-18 18:51 ` Ayan Halder
2019-10-16 17:34 ` John Stultz
2019-09-30 13:40 ` Laura Abbott
[not found] ` <20190930074335.6636-1-hdanton@sina.com>
2019-10-01 20:50 ` [RESEND][PATCH v8 3/5] dma-buf: heaps: Add system heap to dmabuf heaps John Stultz
[not found] ` <20190930032651.8264-1-hdanton@sina.com>
2019-10-02 16:14 ` [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework John Stultz
[not found] ` <20190930081434.248-1-hdanton@sina.com>
2019-10-02 16:15 ` [RESEND][PATCH v8 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927092017.zh2srpk3m4wxha4c@DESKTOP-E1NTVVP.localdomain \
--to=brian.starkey@arm.com \
--cc=Sudipto.Paul@arm.com \
--cc=Vincent.Donnefort@arm.com \
--cc=afd@ti.com \
--cc=astrachan@google.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengc@google.com \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=nd@arm.com \
--cc=pratikp@codeaurora.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).