From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Naveen Rao <naveen.n.rao@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH] tracing/probe: Test nr_args match in looking for same probe events
Date: Fri, 27 Sep 2019 23:24:05 +0530 [thread overview]
Message-ID: <20190927175405.GA7088@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190927105019.661591cd@oasis.local.home>
> >
> > This has a side-effect where the newer probe has same argument commands, we
> > still end up appending the probe.
>
> ??
>
> How so?
>
> If the two have the same number of arguments we do exactly what we did
> before this patch. Please explain to me how that side effect would happen?
>
> It basically is doing, "if the two probes do not have the same number
> of arguments, don't bother comparing, because they are different."
>
Lets take the first probe has 3 arguments passed to it and the second probe
has just 2 arguments. If the first two arguments are same type, name, and
comm, should we append to the first probe? I think No, I would believe we
should append only if the comm of either of the arguments was different.
Example:
echo p:test _do_fork arg1=%ax arg2=%bx arg3=%cx >> kprobe_events
echo p:test _do_fork arg1=%ax arg2=%bx >> kprobe_events
next prev parent reply other threads:[~2019-09-27 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 9:50 [PATCH] tracing/probe: Test nr_args match in looking for same probe events Steven Rostedt
2019-09-27 13:38 ` Srikar Dronamraju
2019-09-27 15:06 ` Steven Rostedt
2019-09-27 17:54 ` Srikar Dronamraju [this message]
2019-09-28 8:17 ` Masami Hiramatsu
2019-09-28 9:56 ` Masami Hiramatsu
2019-09-28 9:59 ` [PATCH] tracing/probe: Fix to check the difference of nr_args before adding probe Masami Hiramatsu
2019-09-28 21:11 ` Steven Rostedt
2019-09-29 8:14 ` Masami Hiramatsu
2019-09-30 10:28 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927175405.GA7088@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).