From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Naveen Rao <naveen.n.rao@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests/ftrace: Fix same probe error test
Date: Sat, 28 Sep 2019 00:56:56 -0700 [thread overview]
Message-ID: <20190928005656.cf7553118ebf292a3d44a59d@kernel.org> (raw)
In-Reply-To: <20190927112514.00cc6e92@oasis.local.home>
On Fri, 27 Sep 2019 11:25:14 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
>
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> The "same probe" selftest that tests that adding the same probe fails
> doesn't add the same probe and passes, which fails the test.
>
> Fixes: b78b94b82122 ("selftests/ftrace: Update kprobe event error testcase")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Oops, thanks!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> index 8a4025e912cb..ef1e9bafb098 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> @@ -95,7 +95,7 @@ echo 'p:kprobes/testevent _do_fork abcd=\1' > kprobe_events
> check_error 'p:kprobes/testevent _do_fork ^bcd=\1' # DIFF_ARG_TYPE
> check_error 'p:kprobes/testevent _do_fork ^abcd=\1:u8' # DIFF_ARG_TYPE
> check_error 'p:kprobes/testevent _do_fork ^abcd=\"foo"' # DIFF_ARG_TYPE
> -check_error '^p:kprobes/testevent _do_fork' # SAME_PROBE
> +check_error '^p:kprobes/testevent _do_fork abcd=\1' # SAME_PROBE
> fi
>
> exit 0
> --
> 2.20.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2019-09-28 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 15:25 [PATCH] selftests/ftrace: Fix same probe error test Steven Rostedt
2019-09-28 7:56 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190928005656.cf7553118ebf292a3d44a59d@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).