From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Jay Cliburn <jcliburn@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] net: ag71xx: fix mdio subnode support
Date: Mon, 30 Sep 2019 15:42:09 +0200 [thread overview]
Message-ID: <20190930134209.GB14745@lunn.ch> (raw)
In-Reply-To: <20190930093310.10762-1-o.rempel@pengutronix.de>
On Mon, Sep 30, 2019 at 11:33:10AM +0200, Oleksij Rempel wrote:
> The driver was working with fixed phy without any noticeable issues. This bug
> was uncovered by introducing dsa ar9331-switch driver.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/net/ethernet/atheros/ag71xx.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
> index 6703960c7cf5..d1101eea15c2 100644
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -526,7 +526,7 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
> struct device *dev = &ag->pdev->dev;
> struct net_device *ndev = ag->ndev;
> static struct mii_bus *mii_bus;
> - struct device_node *np;
> + struct device_node *np, *mnp;
> int err;
>
> np = dev->of_node;
> @@ -571,7 +571,9 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
> msleep(200);
> }
>
> - err = of_mdiobus_register(mii_bus, np);
> + mnp = of_get_child_by_name(np, "mdio");
> + err = of_mdiobus_register(mii_bus, mnp);
> + of_node_put(mnp);
> if (err)
> goto mdio_err_put_clk;
Hi Oleksij
You need to keep backwards compatibility here. If you find an mdio
node, use it, but if not, you need to still register np.
This is also extending the driver binding, so you need to update the
binding documentation.
Andrew
next prev parent reply other threads:[~2019-09-30 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 9:33 [PATCH v1] net: ag71xx: fix mdio subnode support Oleksij Rempel
2019-09-30 13:42 ` Andrew Lunn [this message]
2019-09-30 14:29 ` Oleksij Rempel
2019-09-30 16:25 ` Andrew Lunn
2019-09-30 17:52 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930134209.GB14745@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=jcliburn@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).