From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jay Cliburn <jcliburn@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v1] net: ag71xx: fix mdio subnode support
Date: Mon, 30 Sep 2019 16:29:07 +0200 [thread overview]
Message-ID: <20190930142907.wo3tahtg7g7mvfmp@pengutronix.de> (raw)
In-Reply-To: <20190930134209.GB14745@lunn.ch>
On Mon, Sep 30, 2019 at 03:42:09PM +0200, Andrew Lunn wrote:
> On Mon, Sep 30, 2019 at 11:33:10AM +0200, Oleksij Rempel wrote:
> > The driver was working with fixed phy without any noticeable issues. This bug
> > was uncovered by introducing dsa ar9331-switch driver.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > drivers/net/ethernet/atheros/ag71xx.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
> > index 6703960c7cf5..d1101eea15c2 100644
> > --- a/drivers/net/ethernet/atheros/ag71xx.c
> > +++ b/drivers/net/ethernet/atheros/ag71xx.c
> > @@ -526,7 +526,7 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
> > struct device *dev = &ag->pdev->dev;
> > struct net_device *ndev = ag->ndev;
> > static struct mii_bus *mii_bus;
> > - struct device_node *np;
> > + struct device_node *np, *mnp;
> > int err;
> >
> > np = dev->of_node;
> > @@ -571,7 +571,9 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
> > msleep(200);
> > }
> >
> > - err = of_mdiobus_register(mii_bus, np);
> > + mnp = of_get_child_by_name(np, "mdio");
> > + err = of_mdiobus_register(mii_bus, mnp);
> > + of_node_put(mnp);
> > if (err)
> > goto mdio_err_put_clk;
>
> Hi Oleksij
>
> You need to keep backwards compatibility here. If you find an mdio
> node, use it, but if not, you need to still register np.
>
> This is also extending the driver binding, so you need to update the
> binding documentation.
Hi Andrew,
Normally i would agree. But in this case:
- this driver is freshly added to the kernel and is different to OpenWrt
implementation any way. No users from this side.
- Devicetree binding says:
Documentation/devicetree/bindings/net/qca,ar71xx.txt
|Optional properties:
|- phy-handle : phandle to the PHY device connected to this device.
|- fixed-link : Assume a fixed link. See fixed-link.txt in the same directory.
| Use instead of phy-handle.
|
|Optional subnodes:
|- mdio : specifies the mdio bus, used as a container for phy nodes
| according to phy.txt in the same directory
So, it is driver bug ...ooOO (my personal bug :D)
I would say: if some one already started to use this driver, didn't used
documentation and didn't reported this bug, can't really blame any one
here :)
Regards,
Oleksij
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2019-09-30 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 9:33 [PATCH v1] net: ag71xx: fix mdio subnode support Oleksij Rempel
2019-09-30 13:42 ` Andrew Lunn
2019-09-30 14:29 ` Oleksij Rempel [this message]
2019-09-30 16:25 ` Andrew Lunn
2019-09-30 17:52 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930142907.wo3tahtg7g7mvfmp@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=jcliburn@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).