linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: fix memory.low description in cgroup-v2.rst
@ 2019-09-25 19:56 Jon Haslam
  2019-09-25 19:58 ` Roman Gushchin
  2019-10-01 12:53 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: Jon Haslam @ 2019-09-25 19:56 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-doc, corbet, hannes, tj, guro, Jon Haslam

The current cgroup-v2.rst file contains an incorrect description of when
memory is reclaimed from a cgroup that is using the 'memory.low'
mechanism. This fix simply corrects the text to reflect the actual
implementation.

Fixes: 7854207fe954 ("mm/docs: describe memory.low refinements")
Signed-off-by: Jon Haslam <jonhaslam@fb.com>
---
 Documentation/admin-guide/cgroup-v2.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 0fa8c0e615c2..26d1cde6b34a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1117,8 +1117,8 @@ PAGE_SIZE multiple when read back.
 
 	Best-effort memory protection.  If the memory usage of a
 	cgroup is within its effective low boundary, the cgroup's
-	memory won't be reclaimed unless memory can be reclaimed
-	from unprotected cgroups.
+	memory won't be reclaimed unless there is no reclaimable
+	memory available in unprotected cgroups.
 
 	Effective low boundary is limited by memory.low values of
 	all ancestor cgroups. If there is memory.low overcommitment
@@ -1914,7 +1914,7 @@ Cpuset Interface Files
 
         It accepts only the following input values when written to.
 
-        "root"   - a paritition root
+        "root"   - a partition root
         "member" - a non-root member of a partition
 
 	When set to be a partition root, the current cgroup is the
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: fix memory.low description in cgroup-v2.rst
  2019-09-25 19:56 [PATCH] docs: fix memory.low description in cgroup-v2.rst Jon Haslam
@ 2019-09-25 19:58 ` Roman Gushchin
  2019-10-01 12:53 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Roman Gushchin @ 2019-09-25 19:58 UTC (permalink / raw)
  To: Jonathan Haslam; +Cc: linux-kernel, linux-doc, corbet, hannes, tj

On Wed, Sep 25, 2019 at 12:56:04PM -0700, Jon Haslam wrote:
> The current cgroup-v2.rst file contains an incorrect description of when
> memory is reclaimed from a cgroup that is using the 'memory.low'
> mechanism. This fix simply corrects the text to reflect the actual
> implementation.
> 
> Fixes: 7854207fe954 ("mm/docs: describe memory.low refinements")
> Signed-off-by: Jon Haslam <jonhaslam@fb.com>

Acked-by: Roman Gushchin <guro@fb.com>

Thanks, Jon!

> ---
>  Documentation/admin-guide/cgroup-v2.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 0fa8c0e615c2..26d1cde6b34a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1117,8 +1117,8 @@ PAGE_SIZE multiple when read back.
>  
>  	Best-effort memory protection.  If the memory usage of a
>  	cgroup is within its effective low boundary, the cgroup's
> -	memory won't be reclaimed unless memory can be reclaimed
> -	from unprotected cgroups.
> +	memory won't be reclaimed unless there is no reclaimable
> +	memory available in unprotected cgroups.
>  
>  	Effective low boundary is limited by memory.low values of
>  	all ancestor cgroups. If there is memory.low overcommitment
> @@ -1914,7 +1914,7 @@ Cpuset Interface Files
>  
>          It accepts only the following input values when written to.
>  
> -        "root"   - a paritition root
> +        "root"   - a partition root
>          "member" - a non-root member of a partition
>  
>  	When set to be a partition root, the current cgroup is the
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: fix memory.low description in cgroup-v2.rst
  2019-09-25 19:56 [PATCH] docs: fix memory.low description in cgroup-v2.rst Jon Haslam
  2019-09-25 19:58 ` Roman Gushchin
@ 2019-10-01 12:53 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2019-10-01 12:53 UTC (permalink / raw)
  To: Jon Haslam; +Cc: linux-kernel, linux-doc, hannes, tj, guro

On Wed, 25 Sep 2019 12:56:04 -0700
Jon Haslam <jonhaslam@fb.com> wrote:

> The current cgroup-v2.rst file contains an incorrect description of when
> memory is reclaimed from a cgroup that is using the 'memory.low'
> mechanism. This fix simply corrects the text to reflect the actual
> implementation.
> 
> Fixes: 7854207fe954 ("mm/docs: describe memory.low refinements")
> Signed-off-by: Jon Haslam <jonhaslam@fb.com>

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-01 12:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 19:56 [PATCH] docs: fix memory.low description in cgroup-v2.rst Jon Haslam
2019-09-25 19:58 ` Roman Gushchin
2019-10-01 12:53 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).