* [PATCH] backlight: pwm_bl: Add missing curly branches in else branch
@ 2019-10-03 21:35 Matthias Kaehlcke
2019-10-04 9:53 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2019-10-03 21:35 UTC (permalink / raw)
To: Thierry Reding, Lee Jones, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz
Cc: Matthias Kaehlcke, linux-pwm, linux-fbdev, dri-devel, linux-kernel
Add curly braces to an 'else' branch in pwm_backlight_update_status()
to match the corresponding 'if' branch.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/video/backlight/pwm_bl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 746eebc411df..130abff2705f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -125,8 +125,9 @@ static int pwm_backlight_update_status(struct backlight_device *bl)
state.duty_cycle = compute_duty_cycle(pb, brightness);
pwm_apply_state(pb->pwm, &state);
pwm_backlight_power_on(pb);
- } else
+ } else {
pwm_backlight_power_off(pb);
+ }
if (pb->notify_after)
pb->notify_after(pb->dev, brightness);
--
2.23.0.444.g18eeb5a265-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] backlight: pwm_bl: Add missing curly branches in else branch
2019-10-03 21:35 [PATCH] backlight: pwm_bl: Add missing curly branches in else branch Matthias Kaehlcke
@ 2019-10-04 9:53 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2019-10-04 9:53 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Thierry Reding, Lee Jones, Jingoo Han, Bartlomiej Zolnierkiewicz,
linux-pwm, linux-fbdev, dri-devel, linux-kernel
On Thu, Oct 03, 2019 at 02:35:02PM -0700, Matthias Kaehlcke wrote:
> Add curly braces to an 'else' branch in pwm_backlight_update_status()
> to match the corresponding 'if' branch.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
>
> drivers/video/backlight/pwm_bl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 746eebc411df..130abff2705f 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -125,8 +125,9 @@ static int pwm_backlight_update_status(struct backlight_device *bl)
> state.duty_cycle = compute_duty_cycle(pb, brightness);
> pwm_apply_state(pb->pwm, &state);
> pwm_backlight_power_on(pb);
> - } else
> + } else {
> pwm_backlight_power_off(pb);
> + }
>
> if (pb->notify_after)
> pb->notify_after(pb->dev, brightness);
> --
> 2.23.0.444.g18eeb5a265-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-04 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03 21:35 [PATCH] backlight: pwm_bl: Add missing curly branches in else branch Matthias Kaehlcke
2019-10-04 9:53 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).