From: Will Deacon <will@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
suzuki.poulose@arm.com, mark.brown@arm.com
Subject: Re: [PATCH 1/4] arm64: cpufeature: Effectively expose FRINT capability to userspace
Date: Fri, 4 Oct 2019 11:36:33 +0100 [thread overview]
Message-ID: <20191004103632.lnkyxq2h2owdf7c4@willie-the-truck> (raw)
In-Reply-To: <20191003111211.483-2-julien.grall@arm.com>
On Thu, Oct 03, 2019 at 12:12:08PM +0100, Julien Grall wrote:
> The HWCAP framework will detect a new capability based on the sanitized
> version of the ID registers.
>
> Sanitization is based on a whitelist, so any field not described will end
> up to be zeroed.
>
> At the moment, ID_AA64ISAR1_EL1.FRINTTS is not described in
> ftr_id_aa64isar1. This means the field will be zeroed and therefore the
> userspace will not be able to see the HWCAP even if the hardware
> supports the feature.
>
> This can be fixed by describing the field in ftr_id_aa64isar1.
>
> Fixes: ca9503fc9e98 ("arm64: Expose FRINT capabilities to userspace")
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Cc: mark.brown@arm.com
> ---
> arch/arm64/kernel/cpufeature.c | 1 +
> 1 file changed, 1 insertion(+)
D'oh, we should've caught this in testing. Queued as a fix.
Will
next prev parent reply other threads:[~2019-10-04 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 11:12 [PATCH 0/4] arm64/cpufeature: Fix + doc update Julien Grall
2019-10-03 11:12 ` [PATCH 1/4] arm64: cpufeature: Effectively expose FRINT capability to userspace Julien Grall
2019-10-04 10:36 ` Will Deacon [this message]
2019-10-03 11:12 ` [PATCH 2/4] docs/arm64: elf_hwcaps: sort the HWCAP{,2} documentation by ascending value Julien Grall
2019-10-03 11:12 ` [PATCH 3/4] docs/arm64: elf_hwcaps: Document HWCAP_SB Julien Grall
2019-10-03 11:12 ` [PATCH 4/4] docs/arm64: cpu-feature-registers: Documents missing visible fields Julien Grall
2019-10-31 16:48 ` Julien Grall
2019-10-31 17:15 ` Catalin Marinas
2019-10-04 10:37 ` [PATCH 0/4] arm64/cpufeature: Fix + doc update Will Deacon
2019-10-04 16:29 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004103632.lnkyxq2h2owdf7c4@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=julien.grall@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.brown@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).