From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
tanhuazhong@huawei.com, linyunsheng@huawei.com,
lipeng321@huawei.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hns3: make array tick_array static, makes object smaller
Date: Mon, 07 Oct 2019 16:01:03 +0200 (CEST) [thread overview]
Message-ID: <20191007.160103.449489515941198973.davem@davemloft.net> (raw)
In-Reply-To: <20191007110935.32607-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Mon, 7 Oct 2019 12:09:35 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array tick_array on the stack but instead make it
> static. Makes the object code smaller by 29 bytes.
>
> Before:
> text data bss dec hex filename
> 19191 432 0 19623 4ca7 hisilicon/hns3/hns3pf/hclge_tm.o
>
> After:
> text data bss dec hex filename
> 19098 496 0 19594 4c8a hisilicon/hns3/hns3pf/hclge_tm.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2019-10-07 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 11:09 [PATCH] net: hns3: make array tick_array static, makes object smaller Colin King
2019-10-07 14:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007.160103.449489515941198973.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).