* [PATCH v2] drm: bridge: adv7511: Enable SPDIF DAI
@ 2019-10-07 10:06 ` Bogdan Togorean
2019-10-11 7:33 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Bogdan Togorean @ 2019-10-07 10:06 UTC (permalink / raw)
To: dri-devel
Cc: airlied, daniel, narmstrong, a.hajda, Laurent.pinchart, jonas,
jernej.skrabec, allison, tglx, rfontana, linux-kernel,
Bogdan Togorean
ADV7511 support I2S or SPDIF as audio input interfaces. This commit
enable support for SPDIF.
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
Changes in v2:
- add forgotten break statement
drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
index a428185be2c1..1e9b128d229b 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
@@ -119,6 +119,9 @@ int adv7511_hdmi_hw_params(struct device *dev, void *data,
audio_source = ADV7511_AUDIO_SOURCE_I2S;
i2s_format = ADV7511_I2S_FORMAT_LEFT_J;
break;
+ case HDMI_SPDIF:
+ audio_source = ADV7511_AUDIO_SOURCE_SPDIF;
+ break;
default:
return -EINVAL;
}
@@ -175,11 +178,21 @@ static int audio_startup(struct device *dev, void *data)
/* use Audio infoframe updated info */
regmap_update_bits(adv7511->regmap, ADV7511_REG_GC(1),
BIT(5), 0);
+ /* enable SPDIF receiver */
+ if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
+ regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
+ BIT(7), BIT(7));
+
return 0;
}
static void audio_shutdown(struct device *dev, void *data)
{
+ struct adv7511 *adv7511 = dev_get_drvdata(dev);
+
+ if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
+ regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
+ BIT(7), 0);
}
static int adv7511_hdmi_i2s_get_dai_id(struct snd_soc_component *component,
@@ -213,6 +226,7 @@ static const struct hdmi_codec_pdata codec_data = {
.ops = &adv7511_codec_ops,
.max_i2s_channels = 2,
.i2s = 1,
+ .spdif = 1,
};
int adv7511_audio_init(struct device *dev, struct adv7511 *adv7511)
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm: bridge: adv7511: Enable SPDIF DAI
2019-10-07 10:06 ` [PATCH v2] drm: bridge: adv7511: Enable SPDIF DAI Bogdan Togorean
@ 2019-10-11 7:33 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2019-10-11 7:33 UTC (permalink / raw)
To: Bogdan Togorean, dri-devel
Cc: airlied, daniel, narmstrong, Laurent.pinchart, jonas,
jernej.skrabec, allison, tglx, rfontana, linux-kernel
On 07.10.2019 12:06, Bogdan Togorean wrote:
> ADV7511 support I2S or SPDIF as audio input interfaces. This commit
> enable support for SPDIF.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Let's wait few days with queuing, with hope somebody will test it.
--
Regards
Andrzej
> ---
>
> Changes in v2:
> - add forgotten break statement
>
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index a428185be2c1..1e9b128d229b 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -119,6 +119,9 @@ int adv7511_hdmi_hw_params(struct device *dev, void *data,
> audio_source = ADV7511_AUDIO_SOURCE_I2S;
> i2s_format = ADV7511_I2S_FORMAT_LEFT_J;
> break;
> + case HDMI_SPDIF:
> + audio_source = ADV7511_AUDIO_SOURCE_SPDIF;
> + break;
> default:
> return -EINVAL;
> }
> @@ -175,11 +178,21 @@ static int audio_startup(struct device *dev, void *data)
> /* use Audio infoframe updated info */
> regmap_update_bits(adv7511->regmap, ADV7511_REG_GC(1),
> BIT(5), 0);
> + /* enable SPDIF receiver */
> + if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> + regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> + BIT(7), BIT(7));
> +
> return 0;
> }
>
> static void audio_shutdown(struct device *dev, void *data)
> {
> + struct adv7511 *adv7511 = dev_get_drvdata(dev);
> +
> + if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> + regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> + BIT(7), 0);
> }
>
> static int adv7511_hdmi_i2s_get_dai_id(struct snd_soc_component *component,
> @@ -213,6 +226,7 @@ static const struct hdmi_codec_pdata codec_data = {
> .ops = &adv7511_codec_ops,
> .max_i2s_channels = 2,
> .i2s = 1,
> + .spdif = 1,
> };
>
> int adv7511_audio_init(struct device *dev, struct adv7511 *adv7511)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-11 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191007100945epcas2p15319b2e323c67b9ed8a5a4f56f5f7e7a@epcas2p1.samsung.com>
2019-10-07 10:06 ` [PATCH v2] drm: bridge: adv7511: Enable SPDIF DAI Bogdan Togorean
2019-10-11 7:33 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).