[PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk
@ 2019-09-19  5:05 Anson Huang
  2019-09-19  5:05 ` [PATCH 2/3] arm64: dts: imx8mm: " Anson Huang
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Anson Huang @ 2019-09-19  5:05 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	leonard.crestez, daniel.lezcano, ping.bai, daniel.baluta, jun.li,
	l.stach, abel.vesa, andrew.smirnov, angus, ccaione, agx,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

On i.MX8MQ, usdhc's ipg clock is from IMX8MQ_CLK_IPG_ROOT,
assign it explicitly instead of using IMX8MQ_CLK_DUMMY.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index fd42bee..e2c95ad 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -850,7 +850,7 @@
 				             "fsl,imx7d-usdhc";
 				reg = <0x30b40000 0x10000>;
 				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MQ_CLK_DUMMY>,
+				clocks = <&clk IMX8MQ_CLK_IPG_ROOT>,
 				         <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
 				         <&clk IMX8MQ_CLK_USDHC1_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -867,7 +867,7 @@
 				             "fsl,imx7d-usdhc";
 				reg = <0x30b50000 0x10000>;
 				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MQ_CLK_DUMMY>,
+				clocks = <&clk IMX8MQ_CLK_IPG_ROOT>,
 				         <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
 				         <&clk IMX8MQ_CLK_USDHC2_ROOT>;
 				clock-names = "ipg", "ahb", "per";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk
  2019-09-19  5:05 [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk Anson Huang
@ 2019-09-19  5:05 ` Anson Huang
  2019-09-19  7:17   ` Schrempf Frieder
  2019-09-19  5:05 ` [PATCH 3/3] arm64: dts: imx8mn: " Anson Huang
  2019-10-07 12:12 ` [PATCH 1/3] arm64: dts: imx8mq: " Shawn Guo
  2 siblings, 1 reply; 8+ messages in thread
From: Anson Huang @ 2019-09-19  5:05 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	leonard.crestez, daniel.lezcano, ping.bai, daniel.baluta, jun.li,
	l.stach, abel.vesa, andrew.smirnov, angus, ccaione, agx,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

On i.MX8MM, usdhc's ipg clock is from IMX8MM_CLK_IPG_ROOT,
assign it explicitly instead of using IMX8MM_CLK_DUMMY.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 7c4dcce..8aafad2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -694,7 +694,7 @@
 				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b40000 0x10000>;
 				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MM_CLK_DUMMY>,
+				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
 					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MM_CLK_USDHC1_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -710,7 +710,7 @@
 				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b50000 0x10000>;
 				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MM_CLK_DUMMY>,
+				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
 					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MM_CLK_USDHC2_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -724,7 +724,7 @@
 				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b60000 0x10000>;
 				interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MM_CLK_DUMMY>,
+				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
 					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MM_CLK_USDHC3_ROOT>;
 				clock-names = "ipg", "ahb", "per";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk
  2019-09-19  5:05 ` [PATCH 2/3] arm64: dts: imx8mm: " Anson Huang
@ 2019-09-19  7:17   ` Schrempf Frieder
  2019-09-19  9:31     ` Anson Huang
  0 siblings, 1 reply; 8+ messages in thread
From: Schrempf Frieder @ 2019-09-19  7:17 UTC (permalink / raw)
  To: Anson Huang, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, leonard.crestez, daniel.lezcano, ping.bai,
	daniel.baluta, jun.li, l.stach, abel.vesa, andrew.smirnov, angus,
	ccaione, agx, devicetree, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

Hi Anson,

I have a question, that is not directly related to this patch.
I see that for the usdhc1 and usdhc3 nodes, there is an 'assigned-clock' 
and 'assigned-clock-rates' property but not for usdhc2. The same applies 
to the mx8mq and mx8mn dtsi file.

Is there any reason for this? If not can you fix it?

Thanks,
Frieder

On 19.09.19 07:05, Anson Huang wrote:
> On i.MX8MM, usdhc's ipg clock is from IMX8MM_CLK_IPG_ROOT,
> assign it explicitly instead of using IMX8MM_CLK_DUMMY.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>   arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 7c4dcce..8aafad2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -694,7 +694,7 @@
>   				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
>   				reg = <0x30b40000 0x10000>;
>   				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MM_CLK_DUMMY>,
> +				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
>   					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
>   					 <&clk IMX8MM_CLK_USDHC1_ROOT>;
>   				clock-names = "ipg", "ahb", "per";
> @@ -710,7 +710,7 @@
>   				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
>   				reg = <0x30b50000 0x10000>;
>   				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MM_CLK_DUMMY>,
> +				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
>   					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
>   					 <&clk IMX8MM_CLK_USDHC2_ROOT>;
>   				clock-names = "ipg", "ahb", "per";
> @@ -724,7 +724,7 @@
>   				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
>   				reg = <0x30b60000 0x10000>;
>   				interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MM_CLK_DUMMY>,
> +				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
>   					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
>   					 <&clk IMX8MM_CLK_USDHC3_ROOT>;
>   				clock-names = "ipg", "ahb", "per";
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk
  2019-09-19  7:17   ` Schrempf Frieder
@ 2019-09-19  9:31     ` Anson Huang
  2019-09-19 10:04       ` Schrempf Frieder
  0 siblings, 1 reply; 8+ messages in thread
From: Anson Huang @ 2019-09-19  9:31 UTC (permalink / raw)
  To: Schrempf Frieder, robh+dt, mark.rutland, shawnguo, s.hauer,
	kernel, festevam, Leonard Crestez, daniel.lezcano, Jacky Bai,
	Daniel Baluta, Jun Li, l.stach, Abel Vesa, andrew.smirnov, angus,
	ccaione, agx, devicetree, linux-arm-kernel, linux-kernel
  Cc: dl-linux-imx

Hi, Schrempf

> Hi Anson,
> 
> I have a question, that is not directly related to this patch.
> I see that for the usdhc1 and usdhc3 nodes, there is an 'assigned-clock'
> and 'assigned-clock-rates' property but not for usdhc2. The same applies to
> the mx8mq and mx8mn dtsi file.
> 
> Is there any reason for this? If not can you fix it?

This patch series is NOT related to 'assigned-clock' or 'assigned-clock-rates'
property, it is just for correcting clock source according to reference manual,
the 'ipg' clock is from system's IPG_ROOT clock according to reference manual CCM
chapter, using DUMMY clock is NOT a good option, the 'ipg' clock is supposed
to be the clock for accessing register, and it should NOT be DUMMY if we know
what exactly the clock source is used.

Thanks,
Anson

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk
  2019-09-19  9:31     ` Anson Huang
@ 2019-09-19 10:04       ` Schrempf Frieder
  0 siblings, 0 replies; 8+ messages in thread
From: Schrempf Frieder @ 2019-09-19 10:04 UTC (permalink / raw)
  To: Anson Huang, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, Leonard Crestez, daniel.lezcano, Jacky Bai,
	Daniel Baluta, Jun Li, l.stach, Abel Vesa, andrew.smirnov, angus,
	ccaione, agx, devicetree, linux-arm-kernel, linux-kernel
  Cc: dl-linux-imx

Hi Anson,

On 19.09.19 11:31, Anson Huang wrote:
> Hi, Schrempf
> 
>> Hi Anson,
>>
>> I have a question, that is not directly related to this patch.
>> I see that for the usdhc1 and usdhc3 nodes, there is an 'assigned-clock'
>> and 'assigned-clock-rates' property but not for usdhc2. The same applies to
>> the mx8mq and mx8mn dtsi file.
>>
>> Is there any reason for this? If not can you fix it?
> 
> This patch series is NOT related to 'assigned-clock' or 'assigned-clock-rates'
> property,

That's exactly what I'm saying. To not cause more confusion, I have sent 
a message in a new thread: 
http://lists.infradead.org/pipermail/linux-arm-kernel/2019-September/681426.html

> it is just for correcting clock source according to reference manual,
> the 'ipg' clock is from system's IPG_ROOT clock according to reference manual CCM
> chapter, using DUMMY clock is NOT a good option, the 'ipg' clock is supposed
> to be the clock for accessing register, and it should NOT be DUMMY if we know
> what exactly the clock source is used.

That's probably right and I didn't mean to question the patch at all.

Thanks,
Frieder

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 3/3] arm64: dts: imx8mn: Use correct clock for usdhc's ipg clk
  2019-09-19  5:05 [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk Anson Huang
  2019-09-19  5:05 ` [PATCH 2/3] arm64: dts: imx8mm: " Anson Huang
@ 2019-09-19  5:05 ` Anson Huang
  2019-10-07 12:12 ` [PATCH 1/3] arm64: dts: imx8mq: " Shawn Guo
  2 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-09-19  5:05 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	leonard.crestez, daniel.lezcano, ping.bai, daniel.baluta, jun.li,
	l.stach, abel.vesa, andrew.smirnov, angus, ccaione, agx,
	devicetree, linux-arm-kernel, linux-kernel
  Cc: Linux-imx

On i.MX8MN, usdhc's ipg clock is from IMX8MN_CLK_IPG_ROOT,
assign it explicitly instead of using IMX8MN_CLK_DUMMY.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 6cb6c9c..725a3a3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -594,7 +594,7 @@
 				compatible = "fsl,imx8mn-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b40000 0x10000>;
 				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MN_CLK_DUMMY>,
+				clocks = <&clk IMX8MN_CLK_IPG_ROOT>,
 					 <&clk IMX8MN_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MN_CLK_USDHC1_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -610,7 +610,7 @@
 				compatible = "fsl,imx8mn-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b50000 0x10000>;
 				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MN_CLK_DUMMY>,
+				clocks = <&clk IMX8MN_CLK_IPG_ROOT>,
 					 <&clk IMX8MN_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MN_CLK_USDHC2_ROOT>;
 				clock-names = "ipg", "ahb", "per";
@@ -624,7 +624,7 @@
 				compatible = "fsl,imx8mn-usdhc", "fsl,imx7d-usdhc";
 				reg = <0x30b60000 0x10000>;
 				interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MN_CLK_DUMMY>,
+				clocks = <&clk IMX8MN_CLK_IPG_ROOT>,
 					 <&clk IMX8MN_CLK_NAND_USDHC_BUS>,
 					 <&clk IMX8MN_CLK_USDHC3_ROOT>;
 				clock-names = "ipg", "ahb", "per";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk
  2019-09-19  5:05 [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk Anson Huang
  2019-09-19  5:05 ` [PATCH 2/3] arm64: dts: imx8mm: " Anson Huang
  2019-09-19  5:05 ` [PATCH 3/3] arm64: dts: imx8mn: " Anson Huang
@ 2019-10-07 12:12 ` Shawn Guo
  2019-10-08  0:58   ` Anson Huang
  2 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2019-10-07 12:12 UTC (permalink / raw)
  To: Anson Huang
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam,
	leonard.crestez, daniel.lezcano, ping.bai, daniel.baluta, jun.li,
	l.stach, abel.vesa, andrew.smirnov, angus, ccaione, agx,
	devicetree, linux-arm-kernel, linux-kernel, Linux-imx

On Thu, Sep 19, 2019 at 01:05:57PM +0800, Anson Huang wrote:
> On i.MX8MQ, usdhc's ipg clock is from IMX8MQ_CLK_IPG_ROOT,
> assign it explicitly instead of using IMX8MQ_CLK_DUMMY.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Fixes tag?

Shawn

> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index fd42bee..e2c95ad 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -850,7 +850,7 @@
>  				             "fsl,imx7d-usdhc";
>  				reg = <0x30b40000 0x10000>;
>  				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MQ_CLK_DUMMY>,
> +				clocks = <&clk IMX8MQ_CLK_IPG_ROOT>,
>  				         <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
>  				         <&clk IMX8MQ_CLK_USDHC1_ROOT>;
>  				clock-names = "ipg", "ahb", "per";
> @@ -867,7 +867,7 @@
>  				             "fsl,imx7d-usdhc";
>  				reg = <0x30b50000 0x10000>;
>  				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MQ_CLK_DUMMY>,
> +				clocks = <&clk IMX8MQ_CLK_IPG_ROOT>,
>  				         <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
>  				         <&clk IMX8MQ_CLK_USDHC2_ROOT>;
>  				clock-names = "ipg", "ahb", "per";
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk
  2019-10-07 12:12 ` [PATCH 1/3] arm64: dts: imx8mq: " Shawn Guo
@ 2019-10-08  0:58   ` Anson Huang
  0 siblings, 0 replies; 8+ messages in thread
From: Anson Huang @ 2019-10-08  0:58 UTC (permalink / raw)
  To: Shawn Guo
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam,
	Leonard Crestez, daniel.lezcano, Jacky Bai, Daniel Baluta,
	Jun Li, l.stach, Abel Vesa, andrew.smirnov, angus, ccaione, agx,
	devicetree, linux-arm-kernel, linux-kernel, dl-linux-imx

Hi, Shawn

> On Thu, Sep 19, 2019 at 01:05:57PM +0800, Anson Huang wrote:
> > On i.MX8MQ, usdhc's ipg clock is from IMX8MQ_CLK_IPG_ROOT, assign it
> > explicitly instead of using IMX8MQ_CLK_DUMMY.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> Fixes tag?

OK, added them in V2.

Thanks,
Anson


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-10-08  0:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19  5:05 [PATCH 1/3] arm64: dts: imx8mq: Use correct clock for usdhc's ipg clk Anson Huang
2019-09-19  5:05 ` [PATCH 2/3] arm64: dts: imx8mm: " Anson Huang
2019-09-19  7:17   ` Schrempf Frieder
2019-09-19  9:31     ` Anson Huang
2019-09-19 10:04       ` Schrempf Frieder
2019-09-19  5:05 ` [PATCH 3/3] arm64: dts: imx8mn: " Anson Huang
2019-10-07 12:12 ` [PATCH 1/3] arm64: dts: imx8mq: " Shawn Guo
2019-10-08  0:58   ` Anson Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).