* [PATCH] staging: vchiq: don't leak kernel address
@ 2019-10-08 12:33 Matteo Croce
2019-10-08 13:15 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Matteo Croce @ 2019-10-08 12:33 UTC (permalink / raw)
To: Eric Anholt, Stefan Wahren, Greg Kroah-Hartman,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-kernel, devel
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
an obfuscated kernel pointer is printed at boot:
vchiq: vchiq_init_state: slot_zero = (____ptrval____)
Remove the the print completely, as it's useless without the address.
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 56a23a297fa4..084cd4b0f07c 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -2132,9 +2132,6 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero)
char threadname[16];
int i;
- vchiq_log_warning(vchiq_core_log_level,
- "%s: slot_zero = %pK", __func__, slot_zero);
-
if (vchiq_states[0]) {
pr_err("%s: VCHIQ state already initialized\n", __func__);
return VCHIQ_ERROR;
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vchiq: don't leak kernel address
2019-10-08 12:33 [PATCH] staging: vchiq: don't leak kernel address Matteo Croce
@ 2019-10-08 13:15 ` Dan Carpenter
2019-10-08 14:21 ` Matteo Croce
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2019-10-08 13:15 UTC (permalink / raw)
To: Matteo Croce
Cc: Eric Anholt, Stefan Wahren, Greg Kroah-Hartman,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-kernel, devel
The subject doesn't match the patch. It should just be "remove useless
printk".
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vchiq: don't leak kernel address
2019-10-08 13:15 ` Dan Carpenter
@ 2019-10-08 14:21 ` Matteo Croce
2019-10-08 14:25 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Matteo Croce @ 2019-10-08 14:21 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman
Cc: Eric Anholt, Stefan Wahren, bcm-kernel-feedback-list,
linux-rpi-kernel, LKML, devel
On Tue, Oct 8, 2019 at 3:16 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The subject doesn't match the patch. It should just be "remove useless
> printk".
>
> regards,
> dan carpenter
>
Well, it avoids leaking an address by removing an useless printk.
It seems that GKH already picked the patch in his staging tree, but
I'm fine with both subjects, really,
Greg?
--
Matteo Croce
per aspera ad upstream
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vchiq: don't leak kernel address
2019-10-08 14:21 ` Matteo Croce
@ 2019-10-08 14:25 ` Dan Carpenter
2019-10-08 15:15 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2019-10-08 14:25 UTC (permalink / raw)
To: Matteo Croce
Cc: Greg Kroah-Hartman, Eric Anholt, Stefan Wahren,
bcm-kernel-feedback-list, linux-rpi-kernel, LKML, devel
On Tue, Oct 08, 2019 at 04:21:54PM +0200, Matteo Croce wrote:
> On Tue, Oct 8, 2019 at 3:16 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The subject doesn't match the patch. It should just be "remove useless
> > printk".
> >
> > regards,
> > dan carpenter
> >
>
> Well, it avoids leaking an address by removing an useless printk.
> It seems that GKH already picked the patch in his staging tree, but
> I'm fine with both subjects, really,
The address wasn't leaked because it was already %pK. The subject
says there is an info leak security problem, when the opposite is true.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vchiq: don't leak kernel address
2019-10-08 14:25 ` Dan Carpenter
@ 2019-10-08 15:15 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2019-10-08 15:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: Matteo Croce, devel, LKML, Eric Anholt, bcm-kernel-feedback-list,
linux-rpi-kernel, Stefan Wahren
On Tue, Oct 08, 2019 at 05:25:17PM +0300, Dan Carpenter wrote:
> On Tue, Oct 08, 2019 at 04:21:54PM +0200, Matteo Croce wrote:
> > On Tue, Oct 8, 2019 at 3:16 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > >
> > > The subject doesn't match the patch. It should just be "remove useless
> > > printk".
> > >
> > > regards,
> > > dan carpenter
> > >
> >
> > Well, it avoids leaking an address by removing an useless printk.
> > It seems that GKH already picked the patch in his staging tree, but
> > I'm fine with both subjects, really,
>
> The address wasn't leaked because it was already %pK. The subject
> says there is an info leak security problem, when the opposite is true.
I've edited the subject line now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-08 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 12:33 [PATCH] staging: vchiq: don't leak kernel address Matteo Croce
2019-10-08 13:15 ` Dan Carpenter
2019-10-08 14:21 ` Matteo Croce
2019-10-08 14:25 ` Dan Carpenter
2019-10-08 15:15 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).