* linux-next: build warning after merge of the sound-asoc tree @ 2019-10-07 23:58 Stephen Rothwell 2019-10-08 23:52 ` [PATCH] ASoC: jz4740: Remove unused match variable Stephen Boyd 0 siblings, 1 reply; 3+ messages in thread From: Stephen Rothwell @ 2019-10-07 23:58 UTC (permalink / raw) To: Mark Brown, Liam Girdwood Cc: Linux Next Mailing List, Linux Kernel Mailing List, Stephen Boyd [-- Attachment #1: Type: text/plain, Size: 492 bytes --] Hi all, After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_dev_probe': sound/soc/jz4740/jz4740-i2s.c:500:29: warning: unused variable 'match' [-Wunused-variable] 500 | const struct of_device_id *match; | ^~~~~ Introduced by commit 67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()") -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ASoC: jz4740: Remove unused match variable 2019-10-07 23:58 linux-next: build warning after merge of the sound-asoc tree Stephen Rothwell @ 2019-10-08 23:52 ` Stephen Boyd 2019-10-09 10:00 ` Applied "ASoC: jz4740: Remove unused match variable" to the asoc tree Mark Brown 0 siblings, 1 reply; 3+ messages in thread From: Stephen Boyd @ 2019-10-08 23:52 UTC (permalink / raw) To: Mark Brown, Liam Girdwood Cc: linux-kernel, Linux Next Mailing List, Stephen Rothwell, Arnd Bergmann, Geert Uytterhoeven, Paul Cercueil, Jaroslav Kysela, Takashi Iwai, Rob Herring, Frank Rowand, alsa-devel After commit 67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()"), the match local variable is unused and the compiler rightly warns. sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_dev_probe': sound/soc/jz4740/jz4740-i2s.c:500:29: warning: unused variable 'match' [-Wunused-variable] 500 | const struct of_device_id *match; Drop it. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Paul Cercueil <paul@crapouillou.net> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Frank Rowand <frowand.list@gmail.com> Cc: <alsa-devel@alsa-project.org> Fixes: 67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()") Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Can also be squashed. Sorry I missed this warning in the compile log. sound/soc/jz4740/jz4740-i2s.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c index d2dab4d24b87..38d48d101783 100644 --- a/sound/soc/jz4740/jz4740-i2s.c +++ b/sound/soc/jz4740/jz4740-i2s.c @@ -497,7 +497,6 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev) struct jz4740_i2s *i2s; struct resource *mem; int ret; - const struct of_device_id *match; i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); if (!i2s) base-commit: 442630f691a1537b7e0cc35e3d580222077549cb -- Sent by a computer through tubes ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Applied "ASoC: jz4740: Remove unused match variable" to the asoc tree 2019-10-08 23:52 ` [PATCH] ASoC: jz4740: Remove unused match variable Stephen Boyd @ 2019-10-09 10:00 ` Mark Brown 0 siblings, 0 replies; 3+ messages in thread From: Mark Brown @ 2019-10-09 10:00 UTC (permalink / raw) To: Stephen Boyd Cc: alsa-devel, alsa-devel, Arnd Bergmann, Frank Rowand, Geert Uytterhoeven, Jaroslav Kysela, Liam Girdwood, linux-kernel, Linux Next Mailing List, Mark Brown, Paul Cercueil, Rob Herring, Stephen Rothwell, Takashi Iwai The patch ASoC: jz4740: Remove unused match variable has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From ad4abed36433a4fc18d21c0f0eaede84006f219f Mon Sep 17 00:00:00 2001 From: Stephen Boyd <swboyd@chromium.org> Date: Tue, 8 Oct 2019 16:52:12 -0700 Subject: [PATCH] ASoC: jz4740: Remove unused match variable After commit 67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()"), the match local variable is unused and the compiler rightly warns. sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_dev_probe': sound/soc/jz4740/jz4740-i2s.c:500:29: warning: unused variable 'match' [-Wunused-variable] 500 | const struct of_device_id *match; Drop it. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Paul Cercueil <paul@crapouillou.net> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Frank Rowand <frowand.list@gmail.com> Cc: <alsa-devel@alsa-project.org> Fixes: 67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()") Signed-off-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20191008235212.228856-1-swboyd@chromium.org Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/jz4740/jz4740-i2s.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c index d2dab4d24b87..38d48d101783 100644 --- a/sound/soc/jz4740/jz4740-i2s.c +++ b/sound/soc/jz4740/jz4740-i2s.c @@ -497,7 +497,6 @@ static int jz4740_i2s_dev_probe(struct platform_device *pdev) struct jz4740_i2s *i2s; struct resource *mem; int ret; - const struct of_device_id *match; i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); if (!i2s) -- 2.20.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-09 10:01 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-07 23:58 linux-next: build warning after merge of the sound-asoc tree Stephen Rothwell 2019-10-08 23:52 ` [PATCH] ASoC: jz4740: Remove unused match variable Stephen Boyd 2019-10-09 10:00 ` Applied "ASoC: jz4740: Remove unused match variable" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).