linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] ASoC: soc-dapm: Skip suspending widgets with ignore flag
@ 2019-10-09 10:46 Srinivas Kandagatla
  2019-10-09 16:47 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Kandagatla @ 2019-10-09 10:46 UTC (permalink / raw)
  To: broonie
  Cc: spapothi, alsa-devel, linux-kernel, lgirdwood, vkoul, bgoswami,
	Gopikrishnaiah Anandan, Srinivas Kandagatla

From: Sudheer Papothi <spapothi@codeaurora.org>

For wigdets which have set the suspend ignore flag asoc framework
shouldn't mark them as dirty when ASoC suspend function is called.
This change adds check to skip suspending the widgets with the flag set.

Signed-off-by: Gopikrishnaiah Anandan <agopik@codeaurora.org>
Signed-off-by: Sudheer Papothi <spapothi@codeaurora.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/soc-dapm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 13544f7c850b..4ecfd32e59b8 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -303,6 +303,8 @@ void dapm_mark_endpoints_dirty(struct snd_soc_card *card)
 	mutex_lock(&card->dapm_mutex);
 
 	list_for_each_entry(w, &card->widgets, list) {
+		if (w->ignore_suspend)
+			continue;
 		if (w->is_ep) {
 			dapm_mark_dirty(w, "Rechecking endpoints");
 			if (w->is_ep & SND_SOC_DAPM_EP_SINK)
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] ASoC: soc-dapm: Skip suspending widgets with ignore flag
  2019-10-09 10:46 [RFC PATCH] ASoC: soc-dapm: Skip suspending widgets with ignore flag Srinivas Kandagatla
@ 2019-10-09 16:47 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2019-10-09 16:47 UTC (permalink / raw)
  To: Srinivas Kandagatla
  Cc: spapothi, alsa-devel, linux-kernel, lgirdwood, vkoul, bgoswami,
	Gopikrishnaiah Anandan

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

On Wed, Oct 09, 2019 at 11:46:03AM +0100, Srinivas Kandagatla wrote:
> From: Sudheer Papothi <spapothi@codeaurora.org>
> 
> For wigdets which have set the suspend ignore flag asoc framework
> shouldn't mark them as dirty when ASoC suspend function is called.
> This change adds check to skip suspending the widgets with the flag set.

Why?  The goal here is to ensure we revalidate everything on
resume, and flow any changes out.  It doesn't actually result in
changes in state on these widgets if they're still powered on.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-09 16:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 10:46 [RFC PATCH] ASoC: soc-dapm: Skip suspending widgets with ignore flag Srinivas Kandagatla
2019-10-09 16:47 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).