* [PATCH v2] arm64: dts: ls1028a: fix a compatible issue
@ 2019-10-10 8:33 Yuantian Tang
2019-10-10 22:31 ` Leo Li
2019-10-25 8:26 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Yuantian Tang @ 2019-10-10 8:33 UTC (permalink / raw)
To: shawnguo
Cc: leoyang.li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Yuantian Tang
The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
If the wrong compatible was used, this chip will not be able to
be probed correctly and hence fail to work.
Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
---
v2:
- refine the description
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index 5e14e5a19744..f5da9e8b0d9d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,7 +107,7 @@
status = "okay";
i2c-mux@77 {
- compatible = "nxp,pca9847";
+ compatible = "nxp,pca9547";
reg = <0x77>;
#address-cells = <1>;
#size-cells = <0>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue
2019-10-10 8:33 [PATCH v2] arm64: dts: ls1028a: fix a compatible issue Yuantian Tang
@ 2019-10-10 22:31 ` Leo Li
2019-10-25 8:26 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Leo Li @ 2019-10-10 22:31 UTC (permalink / raw)
To: Andy Tang, shawnguo
Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel, Andy Tang
> -----Original Message-----
> From: Yuantian Tang <andy.tang@nxp.com>
> Sent: Thursday, October 10, 2019 3:34 AM
> To: shawnguo@kernel.org
> Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
> <andy.tang@nxp.com>
> Subject: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue
>
> The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> If the wrong compatible was used, this chip will not be able to be probed
> correctly and hence fail to work.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> v2:
> - refine the description
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5e14e5a19744..f5da9e8b0d9d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,7 +107,7 @@
> status = "okay";
>
> i2c-mux@77 {
> - compatible = "nxp,pca9847";
> + compatible = "nxp,pca9547";
> reg = <0x77>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue
2019-10-10 8:33 [PATCH v2] arm64: dts: ls1028a: fix a compatible issue Yuantian Tang
2019-10-10 22:31 ` Leo Li
@ 2019-10-25 8:26 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-10-25 8:26 UTC (permalink / raw)
To: Yuantian Tang
Cc: leoyang.li, robh+dt, mark.rutland, linux-arm-kernel, devicetree,
linux-kernel
On Thu, Oct 10, 2019 at 04:33:34PM +0800, Yuantian Tang wrote:
> The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847.
> If the wrong compatible was used, this chip will not be able to
> be probed correctly and hence fail to work.
>
> Signed-off-by: Yuantian Tang <andy.tang@nxp.com>
Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
I added the tag and applied the patch. Please take care of adding Fixes
tag for fixes in the future.
Shawn
> ---
> v2:
> - refine the description
> arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 5e14e5a19744..f5da9e8b0d9d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,7 +107,7 @@
> status = "okay";
>
> i2c-mux@77 {
> - compatible = "nxp,pca9847";
> + compatible = "nxp,pca9547";
> reg = <0x77>;
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-25 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 8:33 [PATCH v2] arm64: dts: ls1028a: fix a compatible issue Yuantian Tang
2019-10-10 22:31 ` Leo Li
2019-10-25 8:26 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).