* [PATCH -next] ASoC: atmel: select SND_ATMEL_SOC_DMA for SND_ATMEL_SOC_SSC
@ 2019-10-12 2:42 Mao Wenan
2019-10-12 10:24 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-10-12 2:42 UTC (permalink / raw)
To: codrin.ciubotariu, lgirdwood, broonie, perex, tiwai,
nicolas.ferre, alexandre.belloni, ludovic.desroches, mirq-linux
Cc: alsa-devel, linux-arm-kernel, linux-kernel, kernel-janitors, Mao Wenan
If SND_ATMEL_SOC_SSC_PDC=y and SND_ATMEL_SOC_SSC_DMA=m,
below errors can be found:
sound/soc/atmel/atmel_ssc_dai.o: In function
`atmel_ssc_set_audio':
atmel_ssc_dai.c:(.text+0x6fe): undefined reference to
`atmel_pcm_dma_platform_register'
make: *** [vmlinux] Error 1
After commit 18291410557f ("ASoC: atmel: enable
SOC_SSC_PDC and SOC_SSC_DMA in Kconfig"), SND_ATMEL_SOC_DMA
and SND_ATMEL_SOC_SSC are selected by SND_ATMEL_SOC_SSC_DMA,
SND_ATMEL_SOC_SSC is also selected by SND_ATMEL_SOC_SSC_PDC,
the results are SND_ATMEL_SOC_DMA=m but SND_ATMEL_SOC_SSC=y,
so the errors happen.
This patch make SND_ATMEL_SOC_SSC select SND_ATMEL_SOC_DMA.
Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
sound/soc/atmel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index f118c22..2938f6b 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -19,6 +19,7 @@ config SND_ATMEL_SOC_DMA
config SND_ATMEL_SOC_SSC
tristate
+ select SND_ATMEL_SOC_DMA
config SND_ATMEL_SOC_SSC_PDC
tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ASoC: atmel: select SND_ATMEL_SOC_DMA for SND_ATMEL_SOC_SSC
2019-10-12 2:42 [PATCH -next] ASoC: atmel: select SND_ATMEL_SOC_DMA for SND_ATMEL_SOC_SSC Mao Wenan
@ 2019-10-12 10:24 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-10-12 10:24 UTC (permalink / raw)
To: Mao Wenan
Cc: codrin.ciubotariu, lgirdwood, broonie, perex, tiwai,
nicolas.ferre, ludovic.desroches, mirq-linux, alsa-devel,
linux-arm-kernel, linux-kernel, kernel-janitors
On 12/10/2019 10:42:30+0800, Mao Wenan wrote:
> If SND_ATMEL_SOC_SSC_PDC=y and SND_ATMEL_SOC_SSC_DMA=m,
> below errors can be found:
> sound/soc/atmel/atmel_ssc_dai.o: In function
> `atmel_ssc_set_audio':
> atmel_ssc_dai.c:(.text+0x6fe): undefined reference to
> `atmel_pcm_dma_platform_register'
> make: *** [vmlinux] Error 1
>
> After commit 18291410557f ("ASoC: atmel: enable
> SOC_SSC_PDC and SOC_SSC_DMA in Kconfig"), SND_ATMEL_SOC_DMA
> and SND_ATMEL_SOC_SSC are selected by SND_ATMEL_SOC_SSC_DMA,
> SND_ATMEL_SOC_SSC is also selected by SND_ATMEL_SOC_SSC_PDC,
> the results are SND_ATMEL_SOC_DMA=m but SND_ATMEL_SOC_SSC=y,
> so the errors happen.
>
> This patch make SND_ATMEL_SOC_SSC select SND_ATMEL_SOC_DMA.
>
> Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..2938f6b 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -19,6 +19,7 @@ config SND_ATMEL_SOC_DMA
>
> config SND_ATMEL_SOC_SSC
> tristate
> + select SND_ATMEL_SOC_DMA
>
This is not the solution because this doesn't allow to compile out DMA
and use only PDC. I think Arnd already submitted a proper patch.
> config SND_ATMEL_SOC_SSC_PDC
> tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> --
> 2.7.4
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-12 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-12 2:42 [PATCH -next] ASoC: atmel: select SND_ATMEL_SOC_DMA for SND_ATMEL_SOC_SSC Mao Wenan
2019-10-12 10:24 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).