* [PATCH] arm64: dts: qcom: qcs404-evb: Set vdd_apc regulator in high power mode
@ 2019-10-14 12:09 Niklas Cassel
2019-10-16 8:14 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2019-10-14 12:09 UTC (permalink / raw)
To: Andy Gross
Cc: Niklas Cassel, Bjorn Andersson, Rob Herring, Mark Rutland,
linux-arm-msm, devicetree, linux-kernel
vdd_apc is the regulator that supplies the main CPU cluster.
At sudden CPU load changes, we have noticed invalid page faults on
addresses with all bits shifted, as well as on addresses with individual
bits flipped.
By putting the vdd_apc regulator in high power mode, the voltage drops
during sudden load changes will be less severe, and we have not been able
to reproduce the invalid page faults with the regulator in this mode.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
index 501a7330dbc8..522d3ef72df5 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
@@ -73,6 +73,7 @@
regulator-always-on;
regulator-boot-on;
regulator-name = "vdd_apc";
+ regulator-initial-mode = <1>;
regulator-min-microvolt = <1048000>;
regulator-max-microvolt = <1384000>;
};
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404-evb: Set vdd_apc regulator in high power mode
2019-10-14 12:09 [PATCH] arm64: dts: qcom: qcs404-evb: Set vdd_apc regulator in high power mode Niklas Cassel
@ 2019-10-16 8:14 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-10-16 8:14 UTC (permalink / raw)
To: Niklas Cassel
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Mark Rutland,
linux-arm-msm, devicetree, linux-kernel
On 14-10-19, 14:09, Niklas Cassel wrote:
> vdd_apc is the regulator that supplies the main CPU cluster.
>
> At sudden CPU load changes, we have noticed invalid page faults on
> addresses with all bits shifted, as well as on addresses with individual
> bits flipped.
>
> By putting the vdd_apc regulator in high power mode, the voltage drops
> during sudden load changes will be less severe, and we have not been able
> to reproduce the invalid page faults with the regulator in this mode.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
This seems a good bug fix, maybe CC stable?
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 501a7330dbc8..522d3ef72df5 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -73,6 +73,7 @@
> regulator-always-on;
> regulator-boot-on;
> regulator-name = "vdd_apc";
> + regulator-initial-mode = <1>;
> regulator-min-microvolt = <1048000>;
> regulator-max-microvolt = <1384000>;
> };
> --
> 2.21.0
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-16 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 12:09 [PATCH] arm64: dts: qcom: qcs404-evb: Set vdd_apc regulator in high power mode Niklas Cassel
2019-10-16 8:14 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).