* [PATCH] drm/panfrost: Add missing GPU feature registers
@ 2019-10-14 15:15 Steven Price
2019-10-14 19:05 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Steven Price @ 2019-10-14 15:15 UTC (permalink / raw)
To: Daniel Vetter, David Airlie, Rob Herring, Tomeu Vizoso
Cc: Alyssa Rosenzweig, Steven Price, dri-devel, linux-kernel
Three feature registers were declared but never actually read from the
GPU. Add THREAD_MAX_THREADS, THREAD_MAX_WORKGROUP_SIZE and
THREAD_MAX_BARRIER_SIZE so that the complete set are available.
Fixes: 4bced8bea094 ("drm/panfrost: Export all GPU feature registers")
Signed-off-by: Steven Price <steven.price@arm.com>
---
drivers/gpu/drm/panfrost/panfrost_gpu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index f67ed925c0ef..8822ec13a0d6 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -208,6 +208,9 @@ static void panfrost_gpu_init_features(struct panfrost_device *pfdev)
pfdev->features.mem_features = gpu_read(pfdev, GPU_MEM_FEATURES);
pfdev->features.mmu_features = gpu_read(pfdev, GPU_MMU_FEATURES);
pfdev->features.thread_features = gpu_read(pfdev, GPU_THREAD_FEATURES);
+ pfdev->features.max_threads = gpu_read(pfdev, GPU_THREAD_MAX_THREADS);
+ pfdev->features.thread_max_workgroup_sz = gpu_read(pfdev, GPU_THREAD_MAX_WORKGROUP_SIZE);
+ pfdev->features.thread_max_barrier_sz = gpu_read(pfdev, GPU_THREAD_MAX_BARRIER_SIZE);
pfdev->features.coherency_features = gpu_read(pfdev, GPU_COHERENCY_FEATURES);
for (i = 0; i < 4; i++)
pfdev->features.texture_features[i] = gpu_read(pfdev, GPU_TEXTURE_FEATURES(i));
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panfrost: Add missing GPU feature registers
2019-10-14 15:15 [PATCH] drm/panfrost: Add missing GPU feature registers Steven Price
@ 2019-10-14 19:05 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2019-10-14 19:05 UTC (permalink / raw)
To: Steven Price
Cc: Daniel Vetter, David Airlie, Tomeu Vizoso, Alyssa Rosenzweig,
dri-devel, linux-kernel
On Mon, Oct 14, 2019 at 10:15 AM Steven Price <steven.price@arm.com> wrote:
>
> Three feature registers were declared but never actually read from the
> GPU. Add THREAD_MAX_THREADS, THREAD_MAX_WORKGROUP_SIZE and
> THREAD_MAX_BARRIER_SIZE so that the complete set are available.
>
> Fixes: 4bced8bea094 ("drm/panfrost: Export all GPU feature registers")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied to drm-misc-fixes.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 15:15 [PATCH] drm/panfrost: Add missing GPU feature registers Steven Price
2019-10-14 19:05 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).