* [PATCH] pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq()
@ 2019-10-15 16:07 Ben Dooks (Codethink)
2019-10-17 10:17 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-15 16:07 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks (Codethink),
Lorenzo Pieralisi, Andrew Murray, Bjorn Helgaas, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, linux-pci,
linux-arm-kernel, linux-kernel
Fix __iomem attribute on msg variable passed to readl() in
the decode_msi_hwirq() function. Fixes the following sparse
warning:
drivers/pci/controller/pcie-iproc-msi.c:301:17: warning: incorrect type in argument 1 (different address spaces)
drivers/pci/controller/pcie-iproc-msi.c:301:17: expected void const volatile [noderef] <asn:2> *addr
drivers/pci/controller/pcie-iproc-msi.c:301:17: got unsigned int [usertype] *[assigned] msg
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Andrew Murray <andrew.murray@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
.. (open list)
---
drivers/pci/controller/pcie-iproc-msi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
index 0a3f61be5625..3176ad3ab0e5 100644
--- a/drivers/pci/controller/pcie-iproc-msi.c
+++ b/drivers/pci/controller/pcie-iproc-msi.c
@@ -293,11 +293,12 @@ static const struct irq_domain_ops msi_domain_ops = {
static inline u32 decode_msi_hwirq(struct iproc_msi *msi, u32 eq, u32 head)
{
- u32 *msg, hwirq;
+ u32 __iomem *msg;
+ u32 hwirq;
unsigned int offs;
offs = iproc_msi_eq_offset(msi, eq) + head * sizeof(u32);
- msg = (u32 *)(msi->eq_cpu + offs);
+ msg = (u32 __iomem *)(msi->eq_cpu + offs);
hwirq = readl(msg);
hwirq = (hwirq >> 5) + (hwirq & 0x1f);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq()
2019-10-15 16:07 [PATCH] pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq() Ben Dooks (Codethink)
@ 2019-10-17 10:17 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2019-10-17 10:17 UTC (permalink / raw)
To: Ben Dooks (Codethink)
Cc: linux-kernel, Andrew Murray, Bjorn Helgaas, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, linux-pci,
linux-arm-kernel, linux-kernel
On Tue, Oct 15, 2019 at 05:07:02PM +0100, Ben Dooks (Codethink) wrote:
> Fix __iomem attribute on msg variable passed to readl() in
> the decode_msi_hwirq() function. Fixes the following sparse
> warning:
>
> drivers/pci/controller/pcie-iproc-msi.c:301:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/pci/controller/pcie-iproc-msi.c:301:17: expected void const volatile [noderef] <asn:2> *addr
> drivers/pci/controller/pcie-iproc-msi.c:301:17: got unsigned int [usertype] *[assigned] msg
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Andrew Murray <andrew.murray@arm.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> .. (open list)
> ---
> drivers/pci/controller/pcie-iproc-msi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied to pci/misc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index 0a3f61be5625..3176ad3ab0e5 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -293,11 +293,12 @@ static const struct irq_domain_ops msi_domain_ops = {
>
> static inline u32 decode_msi_hwirq(struct iproc_msi *msi, u32 eq, u32 head)
> {
> - u32 *msg, hwirq;
> + u32 __iomem *msg;
> + u32 hwirq;
> unsigned int offs;
>
> offs = iproc_msi_eq_offset(msi, eq) + head * sizeof(u32);
> - msg = (u32 *)(msi->eq_cpu + offs);
> + msg = (u32 __iomem *)(msi->eq_cpu + offs);
> hwirq = readl(msg);
> hwirq = (hwirq >> 5) + (hwirq & 0x1f);
>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-17 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 16:07 [PATCH] pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq() Ben Dooks (Codethink)
2019-10-17 10:17 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).