From: Maxime Ripard <mripard@kernel.org>
To: codekipper@gmail.com
Cc: wens@csie.org, linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
broonie@kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, be17068@iperbole.bo.it
Subject: Re: [PATCH v6 2/7] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets
Date: Wed, 16 Oct 2019 10:06:53 +0200 [thread overview]
Message-ID: <20191016080653.3seixioa2xiaobd7@gilmour> (raw)
In-Reply-To: <20191016070740.121435-3-codekipper@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
Hi,
On Wed, Oct 16, 2019 at 09:07:35AM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Newer SoCs like the H6 have the channel offset bits in a different
> position to what is on the H3. As we will eventually add multi-
> channel support then create function calls as opposed to regmap
> fields to add support for different devices.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
> sound/soc/sunxi/sun4i-i2s.c | 31 +++++++++++++++++++++++++------
> 1 file changed, 25 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
> index f1a80973c450..875567881f30 100644
> --- a/sound/soc/sunxi/sun4i-i2s.c
> +++ b/sound/soc/sunxi/sun4i-i2s.c
> @@ -157,6 +157,8 @@ struct sun4i_i2s_quirks {
> int (*set_chan_cfg)(const struct sun4i_i2s *,
> const struct snd_pcm_hw_params *);
> int (*set_fmt)(struct sun4i_i2s *, unsigned int);
> + void (*set_txchanoffset)(const struct sun4i_i2s *, int);
> + void (*set_rxchanoffset)(const struct sun4i_i2s *);
The point of removing the regmap_field was that because having a
one-size-fits-all function with regmap_field sort of making the
abstraction was becoming more and more of a burden to maintain.
Having functions for each and every register access is exactly the
same as using regmap_field here, and the issue we adressed is not with
regmap_fields in itself.
If the H6 has a different register layout, then so be it, create a new
set_chan_cfg or set_fmt function for the H6.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-10-16 8:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:07 [PATCH v6 0/7] ASoC: sun4i-i2s: Updates to the driver codekipper
2019-10-16 7:07 ` [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset codekipper
2019-10-16 8:04 ` Maxime Ripard
2019-10-16 8:41 ` Code Kipper
2019-10-16 14:51 ` Maxime Ripard
2019-10-16 7:07 ` [PATCH v6 2/7] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets codekipper
2019-10-16 8:06 ` Maxime Ripard [this message]
2019-10-16 8:25 ` Code Kipper
2019-10-16 14:53 ` Maxime Ripard
2019-10-16 7:07 ` [PATCH v6 3/7] ASoC: sun4i-i2s: Add functions for RX and TX channel enables codekipper
2019-10-16 7:07 ` [PATCH v6 4/7] ASoC: sun4i-i2s: Add functions for RX and TX channel selects codekipper
2019-10-16 7:07 ` [PATCH v6 5/7] ASoC: sun4i-i2s: Add functions for RX and TX channel mapping codekipper
2019-10-16 7:07 ` [PATCH v6 6/7] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible codekipper
2019-10-16 7:07 ` [PATCH v6 7/7] ASoC: sun4i-i2s: Add support for H6 I2S codekipper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016080653.3seixioa2xiaobd7@gilmour \
--to=mripard@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=be17068@iperbole.bo.it \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).