From: Maxime Ripard <mripard@kernel.org>
To: Code Kipper <codekipper@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
"Andrea Venturi (pers)" <be17068@iperbole.bo.it>
Subject: Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset
Date: Wed, 16 Oct 2019 16:51:03 +0200 [thread overview]
Message-ID: <20191016145103.im4h75qi2fcdcmar@gilmour> (raw)
In-Reply-To: <CAEKpxBmNCA4U8-X8iSwOxBZ7T3dp6352S2Kfxc6f5E4N671zvg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Wed, Oct 16, 2019 at 10:41:31AM +0200, Code Kipper wrote:
> On Wed, 16 Oct 2019 at 10:04, Maxime Ripard <mripard@kernel.org> wrote:
> >
> > On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekipper@gmail.com wrote:
> > > From: Marcus Cooper <codekipper@gmail.com>
> > >
> > > On the newer SoCs the offset is used to set the mode of the
> > > connection. As it is to be used elsewhere then it makes sense
> > > to move it to the main structure.
> >
> > Elsewhere where, and to do what?
> Thanks...How does this sound?
>
> As it is to be used to set the same offset for each TX data channel in use
> during multi-channel audio then let's move it to the main structure.
That still doesn't explain why you want to move it to the main
structure. It's there, it's calculated already, and can be used during
multi-channel audio if you set it up in the same function. What you
need to explain is why you can't do it in the same function.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-10-16 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:07 [PATCH v6 0/7] ASoC: sun4i-i2s: Updates to the driver codekipper
2019-10-16 7:07 ` [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset codekipper
2019-10-16 8:04 ` Maxime Ripard
2019-10-16 8:41 ` Code Kipper
2019-10-16 14:51 ` Maxime Ripard [this message]
2019-10-16 7:07 ` [PATCH v6 2/7] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets codekipper
2019-10-16 8:06 ` Maxime Ripard
2019-10-16 8:25 ` Code Kipper
2019-10-16 14:53 ` Maxime Ripard
2019-10-16 7:07 ` [PATCH v6 3/7] ASoC: sun4i-i2s: Add functions for RX and TX channel enables codekipper
2019-10-16 7:07 ` [PATCH v6 4/7] ASoC: sun4i-i2s: Add functions for RX and TX channel selects codekipper
2019-10-16 7:07 ` [PATCH v6 5/7] ASoC: sun4i-i2s: Add functions for RX and TX channel mapping codekipper
2019-10-16 7:07 ` [PATCH v6 6/7] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible codekipper
2019-10-16 7:07 ` [PATCH v6 7/7] ASoC: sun4i-i2s: Add support for H6 I2S codekipper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016145103.im4h75qi2fcdcmar@gilmour \
--to=mripard@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=be17068@iperbole.bo.it \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).