[PATCH] pcmcia: include cs_internal.h for missing declarations

[PATCH] pcmcia: include cs_internal.h for missing declarations

[Ben Dooks (Codethink)]

Include cs_internal.h (and pcmcia/cistpl.h as required by
cs_internal.h) for the declearions of cb_alloc and cb_free
to silence the following sparse warnings;

drivers/pcmcia/cardbus.c:64:11: warning: symbol 'cb_alloc' was not declared. Should it be static?
drivers/pcmcia/cardbus.c:103:6: warning: symbol 'cb_free' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
---
 drivers/pcmcia/cardbus.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c
index c502dfbf66e3..45c8252c8edc 100644
--- a/drivers/pcmcia/cardbus.c
+++ b/drivers/pcmcia/cardbus.c
@@ -22,7 +22,9 @@
 #include <linux/pci.h>
 
 #include <pcmcia/ss.h>
+#include <pcmcia/cistpl.h>
 
+#include "cs_internal.h"
 
 static void cardbus_config_irq_and_cls(struct pci_bus *bus, int irq)
 {
-- 
2.23.0

Re: [PATCH] pcmcia: include cs_internal.h for missing declarations

[Dominik Brodowski]

On Thu, Oct 17, 2019 at 12:40:59PM +0100, Ben Dooks (Codethink) wrote:
> Include cs_internal.h (and pcmcia/cistpl.h as required by
> cs_internal.h) for the declearions of cb_alloc and cb_free
> to silence the following sparse warnings;
> 
> drivers/pcmcia/cardbus.c:64:11: warning: symbol 'cb_alloc' was not declared. Should it be static?
> drivers/pcmcia/cardbus.c:103:6: warning: symbol 'cb_free' was not declared. Should it be static?

Applied to the pcmcia tree (but with ":" instead of ";")

Thanks,
	Dominik