* [PATCH] pcmcia: include <pcmcia/ds.h> for pcmcia_parse_tuple
@ 2019-10-17 11:44 Ben Dooks (Codethink)
2019-11-21 10:03 ` Dominik Brodowski
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-17 11:44 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks (Codethink),
Dominik Brodowski, Greg Kroah-Hartman, linux-kernel
Include <pcmcia/ds.h> for pcmcia_parse_tuple declaration
to fix the following sparse warning:
drivers/pcmcia/cistpl.c:1287:5: warning: symbol 'pcmcia_parse_tuple' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
.. (open list)
---
drivers/pcmcia/cistpl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
index 629359fe3513..cf109d9a1112 100644
--- a/drivers/pcmcia/cistpl.c
+++ b/drivers/pcmcia/cistpl.c
@@ -28,6 +28,7 @@
#include <pcmcia/ss.h>
#include <pcmcia/cisreg.h>
#include <pcmcia/cistpl.h>
+#include <pcmcia/ds.h>
#include "cs_internal.h"
static const u_char mantissa[] = {
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pcmcia: include <pcmcia/ds.h> for pcmcia_parse_tuple
2019-10-17 11:44 [PATCH] pcmcia: include <pcmcia/ds.h> for pcmcia_parse_tuple Ben Dooks (Codethink)
@ 2019-11-21 10:03 ` Dominik Brodowski
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Brodowski @ 2019-11-21 10:03 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: linux-kernel, Greg Kroah-Hartman, linux-kernel
On Thu, Oct 17, 2019 at 12:44:47PM +0100, Ben Dooks (Codethink) wrote:
> Include <pcmcia/ds.h> for pcmcia_parse_tuple declaration
> to fix the following sparse warning:
>
> drivers/pcmcia/cistpl.c:1287:5: warning: symbol 'pcmcia_parse_tuple' was not declared. Should it be static?
Applied to the PCMCIA tree.
Thanks,
Dominik
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-21 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 11:44 [PATCH] pcmcia: include <pcmcia/ds.h> for pcmcia_parse_tuple Ben Dooks (Codethink)
2019-11-21 10:03 ` Dominik Brodowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).