From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] scripts : mksysmap : NM variable missed the value,so fixed
Date: Thu, 17 Oct 2019 22:40:09 +0530 [thread overview]
Message-ID: <20191017171006.GA4995@Gentoo> (raw)
In-Reply-To: <265d9be5-217d-3f67-ba94-095efdcf5787@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
On 08:48 Thu 17 Oct 2019, Randy Dunlap wrote:
>On 10/17/19 3:25 AM, Bhaskar Chowdhury wrote:
>> This patch will provide the missing value for NM variable.
>>
>
>Hi,
>
>Does this patch fix some build error that you have encountered?
>If so, please describe it and how to cause it.
>
Okay, I tried to do that ,the script spit out not finding the nm.
Now, the sole reason being I misread it in the first place.
>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> TO all,
>> Adjusted the subject line, missed in previous one,sorry
>>
>> scripts/mksysmap | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/mksysmap b/scripts/mksysmap
>> index a35acc0d0b82..4b2f45c45f14 100755
>> --- a/scripts/mksysmap
>> +++ b/scripts/mksysmap
>> @@ -40,5 +40,5 @@
>> # 'W' or 'w'. __crc_ are 'A' and placed in the middle
>> # so we just ignore them to let readprofile continue to work.
>> # (At least sparc64 has __crc_ in the middle).
>> -
>> +NM=$(which nm)
>
>That's not the POSIX way to do that. It should be
>
>NM=$(command -v nm)
>
>But why is this needed at all?
>The top-level Makefile exports the NM variable (and many more) to scripts
>that it calls.
>
Misread it.
>> $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
>> --
>> 2.21.0
>>
>
Sorry about the noise. Thanks Randy for catch up lackluster stuff.
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-10-17 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 10:25 [PATCH] scripts : mksysmap : NM variable missed the value,so fixed Bhaskar Chowdhury
2019-10-17 15:48 ` Randy Dunlap
2019-10-17 17:10 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017171006.GA4995@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).