[PATCH] scripts : mksysmap : NM variable missed the value,so fixed

[PATCH] scripts : mksysmap : NM variable missed the value,so fixed

[Bhaskar Chowdhury]

This patch will provide the missing value for NM variable.

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
TO all,
Adjusted the subject line, missed in previous one,sorry

 scripts/mksysmap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/mksysmap b/scripts/mksysmap
index a35acc0d0b82..4b2f45c45f14 100755
--- a/scripts/mksysmap
+++ b/scripts/mksysmap
@@ -40,5 +40,5 @@
 # 'W' or 'w'. __crc_ are 'A' and placed in the middle
 # so we just ignore them to let readprofile continue to work.
 # (At least sparc64 has __crc_ in the middle).
-
+NM=$(which nm)
 $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
--
2.21.0

Re: [PATCH] scripts : mksysmap : NM variable missed the value,so fixed

[Randy Dunlap]

On 10/17/19 3:25 AM, Bhaskar Chowdhury wrote:
> This patch will provide the missing value for NM variable.
> 

Hi,

Does this patch fix some build error that you have encountered?
If so, please describe it and how to cause it.


> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> TO all,
> Adjusted the subject line, missed in previous one,sorry
> 
>  scripts/mksysmap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/mksysmap b/scripts/mksysmap
> index a35acc0d0b82..4b2f45c45f14 100755
> --- a/scripts/mksysmap
> +++ b/scripts/mksysmap
> @@ -40,5 +40,5 @@
>  # 'W' or 'w'. __crc_ are 'A' and placed in the middle
>  # so we just ignore them to let readprofile continue to work.
>  # (At least sparc64 has __crc_ in the middle).
> -
> +NM=$(which nm)

That's not the POSIX way to do that.  It should be

NM=$(command -v nm)

But why is this needed at all?
The top-level Makefile exports the NM variable (and many more) to scripts
that it calls.

>  $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
> --
> 2.21.0
> 


-- 
~Randy

Re: [PATCH] scripts : mksysmap : NM variable missed the value,so fixed

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

On 08:48 Thu 17 Oct 2019, Randy Dunlap wrote:
>On 10/17/19 3:25 AM, Bhaskar Chowdhury wrote:
>> This patch will provide the missing value for NM variable.
>> 
>
>Hi,
>
>Does this patch fix some build error that you have encountered?
>If so, please describe it and how to cause it.
>
Okay, I tried to do that ,the script spit out not finding the nm.
Now, the sole reason being I misread it in the first place.
>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> TO all,
>> Adjusted the subject line, missed in previous one,sorry
>> 
>>  scripts/mksysmap | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/scripts/mksysmap b/scripts/mksysmap
>> index a35acc0d0b82..4b2f45c45f14 100755
>> --- a/scripts/mksysmap
>> +++ b/scripts/mksysmap
>> @@ -40,5 +40,5 @@
>>  # 'W' or 'w'. __crc_ are 'A' and placed in the middle
>>  # so we just ignore them to let readprofile continue to work.
>>  # (At least sparc64 has __crc_ in the middle).
>> -
>> +NM=$(which nm)
>
>That's not the POSIX way to do that.  It should be
>
>NM=$(command -v nm)
>
>But why is this needed at all?
>The top-level Makefile exports the NM variable (and many more) to scripts
>that it calls.
>
Misread it. 
>>  $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
>> --
>> 2.21.0
>> 
>
Sorry about the noise. Thanks Randy for catch up lackluster stuff.
>
>-- 
>~Randy
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]