* [PATCH] ARM: dt: add fxos8700 on gateworks boards
@ 2019-10-18 23:20 Robert Jones
2019-10-21 8:15 ` Marco Felsch
0 siblings, 1 reply; 2+ messages in thread
From: Robert Jones @ 2019-10-18 23:20 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, linux-kernel, linux-arm-kernel, Robert Jones
Add fxos8700 iio imu entries for Gateworks SBCs.
Signed-off-by: Robert Jones <rjones@gateworks.com>
---
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 5 +++++
arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 5 +++++
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 5 +++++
3 files changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
index 1a9a9d9..ffc4449 100644
--- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
@@ -306,6 +306,11 @@
VDDIO-supply = <®_3p3v>;
};
+ fxos8700@1e {
+ compatible = "nxp,fxos8700";
+ reg = <0x1e>;
+ };
+
touchscreen: egalax_ts@4 {
compatible = "eeti,egalax_ts";
reg = <0x04>;
diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
index 54b2bea..ebbd1c8 100644
--- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
@@ -297,6 +297,11 @@
VDDIO-supply = <®_3p3v>;
};
+ fxos8700@1e {
+ compatible = "nxp,fxos8700";
+ reg = <0x1e>;
+ };
+
touchscreen: egalax_ts@4 {
compatible = "eeti,egalax_ts";
reg = <0x04>;
diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
index 1b6c133..67d4725 100644
--- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
@@ -354,6 +354,11 @@
VDDIO-supply = <®_3p3v>;
};
+ fxos8700@1e {
+ compatible = "nxp,fxos8700";
+ reg = <0x1e>;
+ };
+
touchscreen: egalax_ts@4 {
compatible = "eeti,egalax_ts";
reg = <0x04>;
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dt: add fxos8700 on gateworks boards
2019-10-18 23:20 [PATCH] ARM: dt: add fxos8700 on gateworks boards Robert Jones
@ 2019-10-21 8:15 ` Marco Felsch
0 siblings, 0 replies; 2+ messages in thread
From: Marco Felsch @ 2019-10-21 8:15 UTC (permalink / raw)
To: Robert Jones
Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer, devicetree,
linux-kernel, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
Hi Robert,
please don't use 'ARM: dt: ..' instead you should name it 'ARM: dts:
imx6qdl-gw5x:'.
On 19-10-18 16:20, Robert Jones wrote:
> Add fxos8700 iio imu entries for Gateworks SBCs.
>
> Signed-off-by: Robert Jones <rjones@gateworks.com>
> ---
> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 5 +++++
> arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 5 +++++
> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> index 1a9a9d9..ffc4449 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
> @@ -306,6 +306,11 @@
> VDDIO-supply = <®_3p3v>;
> };
>
> + fxos8700@1e {
> + compatible = "nxp,fxos8700";
I grep'd the whole tree and found no such compatible. I don't know the
rule but IMHO if there isn't a driver we shouldn't add the compatible
here.
Regards,
Marco
> + reg = <0x1e>;
> + };
> +
> touchscreen: egalax_ts@4 {
> compatible = "eeti,egalax_ts";
> reg = <0x04>;
> diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> index 54b2bea..ebbd1c8 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> @@ -297,6 +297,11 @@
> VDDIO-supply = <®_3p3v>;
> };
>
> + fxos8700@1e {
> + compatible = "nxp,fxos8700";
> + reg = <0x1e>;
> + };
> +
> touchscreen: egalax_ts@4 {
> compatible = "eeti,egalax_ts";
> reg = <0x04>;
> diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> index 1b6c133..67d4725 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> @@ -354,6 +354,11 @@
> VDDIO-supply = <®_3p3v>;
> };
>
> + fxos8700@1e {
> + compatible = "nxp,fxos8700";
> + reg = <0x1e>;
> + };
> +
> touchscreen: egalax_ts@4 {
> compatible = "eeti,egalax_ts";
> reg = <0x04>;
> --
> 2.9.2
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-21 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 23:20 [PATCH] ARM: dt: add fxos8700 on gateworks boards Robert Jones
2019-10-21 8:15 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).