* [PATCH] drm: Fix DSC throughput mode 0 mask definition
@ 2019-10-21 15:03 Siqueira, Rodrigo
2019-10-21 15:35 ` Harry Wentland
0 siblings, 1 reply; 2+ messages in thread
From: Siqueira, Rodrigo @ 2019-10-21 15:03 UTC (permalink / raw)
To: Wentland, Harry, Li, Sun peng (Leo),
Deucher, Alexander, Cornij, Nikola, Jani Nikula, Manasi Navare,
Ville Syrjälä,
Rodrigo Siqueira
Cc: dri-devel, linux-kernel, amd-gfx
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170
which is not aligned with the spec. This commit replace 15 << 4 by
15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the
specification.
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Nikola Cornij <nikola.cornij@amd.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support)
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
---
include/drm/drm_dp_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index cfadeeef8492..52024049c59e 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -306,7 +306,7 @@
# define DP_DSC_THROUGHPUT_MODE_0_900 (12 << 0)
# define DP_DSC_THROUGHPUT_MODE_0_950 (13 << 0)
# define DP_DSC_THROUGHPUT_MODE_0_1000 (14 << 0)
-# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 4)
+# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 0) /* 1.4a */
# define DP_DSC_THROUGHPUT_MODE_1_MASK (0xf << 4)
# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4
# define DP_DSC_THROUGHPUT_MODE_1_UPSUPPORTED 0
--
2.23.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: Fix DSC throughput mode 0 mask definition
2019-10-21 15:03 [PATCH] drm: Fix DSC throughput mode 0 mask definition Siqueira, Rodrigo
@ 2019-10-21 15:35 ` Harry Wentland
0 siblings, 0 replies; 2+ messages in thread
From: Harry Wentland @ 2019-10-21 15:35 UTC (permalink / raw)
To: Siqueira, Rodrigo, Wentland, Harry, Li, Sun peng (Leo),
Deucher, Alexander, Cornij, Nikola, Jani Nikula, Manasi Navare,
Ville Syrjälä,
Rodrigo Siqueira
Cc: dri-devel, linux-kernel, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1607 bytes --]
On 2019-10-21 11:03 a.m., Siqueira, Rodrigo wrote:
> Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170
> which is not aligned with the spec. This commit replace 15 << 4 by
> 15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the
> specification.
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Nikola Cornij <nikola.cornij@amd.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support)
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> include/drm/drm_dp_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index cfadeeef8492..52024049c59e 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -306,7 +306,7 @@
> # define DP_DSC_THROUGHPUT_MODE_0_900 (12 << 0)
> # define DP_DSC_THROUGHPUT_MODE_0_950 (13 << 0)
> # define DP_DSC_THROUGHPUT_MODE_0_1000 (14 << 0)
> -# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 4)
> +# define DP_DSC_THROUGHPUT_MODE_0_170 (15 << 0) /* 1.4a */
> # define DP_DSC_THROUGHPUT_MODE_1_MASK (0xf << 4)
> # define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4
> # define DP_DSC_THROUGHPUT_MODE_1_UPSUPPORTED 0
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-21 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 15:03 [PATCH] drm: Fix DSC throughput mode 0 mask definition Siqueira, Rodrigo
2019-10-21 15:35 ` Harry Wentland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).