* [PATCH] clocksource/drivers/davinci: Fix memory leak in davinci_timer_register
@ 2019-10-21 20:26 Navid Emamdoost
2019-10-22 9:12 ` Markus Elfring
2019-10-22 9:32 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Navid Emamdoost @ 2019-10-21 20:26 UTC (permalink / raw)
Cc: emamd001, kjlu, smccaman, Navid Emamdoost, Daniel Lezcano,
Thomas Gleixner, linux-kernel
In the impelementation of davinci_timer_register() the allocated memory
for clockevent should be released if request_irq() fails.
Fixes: 721154f972aa ("clocksource/drivers/davinci: Add support for clockevents")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/clocksource/timer-davinci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
index 62745c962049..910d4d2f0d64 100644
--- a/drivers/clocksource/timer-davinci.c
+++ b/drivers/clocksource/timer-davinci.c
@@ -299,6 +299,7 @@ int __init davinci_timer_register(struct clk *clk,
"clockevent/tim12", clockevent);
if (rv) {
pr_err("Unable to request the clockevent interrupt");
+ kfree(clockevent);
return rv;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource/drivers/davinci: Fix memory leak in davinci_timer_register
2019-10-21 20:26 [PATCH] clocksource/drivers/davinci: Fix memory leak in davinci_timer_register Navid Emamdoost
@ 2019-10-22 9:12 ` Markus Elfring
2019-10-22 9:32 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-10-22 9:12 UTC (permalink / raw)
To: Navid Emamdoost, Daniel Lezcano, Bartosz Golaszewski, kernel-janitors
Cc: linux-kernel, Navid Emamdoost, Kangjie Lu, Stephen McCamant,
Thomas Gleixner
> In the impelementation of davinci_timer_register() the allocated memory
> for clockevent should be released if request_irq() fails.
* Please avoid the copying of typos from previous change descriptions.
* Under which circumstances will an “imperative mood” matter for you here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7d194c2100ad2a6dded545887d02754948ca5241#n151
> +++ b/drivers/clocksource/timer-davinci.c
> @@ -299,6 +299,7 @@ int __init davinci_timer_register(struct clk *clk,
> "clockevent/tim12", clockevent);
> if (rv) {
> pr_err("Unable to request the clockevent interrupt");
> + kfree(clockevent);
> return rv;
> }
* Should a complete source code analysis point out that a similar fix
will be needed also in the if branch after a failed call of
the function “clocksource_register_hz”?
* Can any more exception handling become relevant because of previous
resource allocations in this function implementation?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource/drivers/davinci: Fix memory leak in davinci_timer_register
2019-10-21 20:26 [PATCH] clocksource/drivers/davinci: Fix memory leak in davinci_timer_register Navid Emamdoost
2019-10-22 9:12 ` Markus Elfring
@ 2019-10-22 9:32 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-10-22 9:32 UTC (permalink / raw)
To: Navid Emamdoost
Cc: emamd001, kjlu, smccaman, Daniel Lezcano, Thomas Gleixner,
Linux Kernel Mailing List
pon., 21 paź 2019 o 22:26 Navid Emamdoost <navid.emamdoost@gmail.com>
napisał(a):
>
> In the impelementation of davinci_timer_register() the allocated memory
> for clockevent should be released if request_irq() fails.
>
> Fixes: 721154f972aa ("clocksource/drivers/davinci: Add support for clockevents")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/clocksource/timer-davinci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
> index 62745c962049..910d4d2f0d64 100644
> --- a/drivers/clocksource/timer-davinci.c
> +++ b/drivers/clocksource/timer-davinci.c
> @@ -299,6 +299,7 @@ int __init davinci_timer_register(struct clk *clk,
> "clockevent/tim12", clockevent);
> if (rv) {
> pr_err("Unable to request the clockevent interrupt");
> + kfree(clockevent);
> return rv;
> }
>
> --
> 2.17.1
>
Any failure in this driver means the system is fried. I explicitly
didn't bother freeing any resources. Nack.
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-22 9:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 20:26 [PATCH] clocksource/drivers/davinci: Fix memory leak in davinci_timer_register Navid Emamdoost
2019-10-22 9:12 ` Markus Elfring
2019-10-22 9:32 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).