* [PATCH 2/5] MIPS: SGI-IP27: move registering of smp ops into IP27 specific code
2019-10-22 16:13 [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Thomas Bogendoerfer
@ 2019-10-22 16:13 ` Thomas Bogendoerfer
2019-10-22 16:13 ` [PATCH 3/5] MIPS: arc: remove unused stuff Thomas Bogendoerfer
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2019-10-22 16:13 UTC (permalink / raw)
To: Ralf Baechle, Paul Burton, James Hogan, linux-mips, linux-kernel
Calling register_smp_ops() in plat_mem_setup() is still early enough.
So by doing this we could remove the ugly #ifdef CONFIG_SGI_IP27 in
fw/arc/init.c.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
arch/mips/fw/arc/init.c | 7 -------
arch/mips/sgi-ip27/ip27-common.h | 1 +
arch/mips/sgi-ip27/ip27-init.c | 2 ++
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/arch/mips/fw/arc/init.c b/arch/mips/fw/arc/init.c
index 7b663455de6b..4ac6466a8872 100644
--- a/arch/mips/fw/arc/init.c
+++ b/arch/mips/fw/arc/init.c
@@ -54,11 +54,4 @@ void __init prom_init(void)
ArcRead(0, &c, 1, &cnt);
ArcEnterInteractiveMode();
#endif
-#ifdef CONFIG_SGI_IP27
- {
- extern const struct plat_smp_ops ip27_smp_ops;
-
- register_smp_ops(&ip27_smp_ops);
- }
-#endif
}
diff --git a/arch/mips/sgi-ip27/ip27-common.h b/arch/mips/sgi-ip27/ip27-common.h
index e9e9f1dc8c20..3ffbcf9bfd41 100644
--- a/arch/mips/sgi-ip27/ip27-common.h
+++ b/arch/mips/sgi-ip27/ip27-common.h
@@ -5,5 +5,6 @@
extern void ip27_reboot_setup(void);
extern void hub_rt_clock_event_init(void);
+extern const struct plat_smp_ops ip27_smp_ops;
#endif /* __IP27_COMMON_H */
diff --git a/arch/mips/sgi-ip27/ip27-init.c b/arch/mips/sgi-ip27/ip27-init.c
index f48e2b3990f6..d160fb219d6d 100644
--- a/arch/mips/sgi-ip27/ip27-init.c
+++ b/arch/mips/sgi-ip27/ip27-init.c
@@ -120,6 +120,8 @@ void __init plat_mem_setup(void)
u64 p, e, n_mode;
nasid_t nid;
+ register_smp_ops(&ip27_smp_ops);
+
ip27_reboot_setup();
/*
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/5] MIPS: arc: remove unused stuff
2019-10-22 16:13 [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Thomas Bogendoerfer
2019-10-22 16:13 ` [PATCH 2/5] MIPS: SGI-IP27: move registering of smp ops into IP27 specific code Thomas Bogendoerfer
@ 2019-10-22 16:13 ` Thomas Bogendoerfer
2019-10-22 16:13 ` [PATCH 4/5] MIPS: arc: use function argument for passing argc/argv to prom_init_cmdline Thomas Bogendoerfer
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2019-10-22 16:13 UTC (permalink / raw)
To: Ralf Baechle, Paul Burton, James Hogan, linux-mips, linux-kernel
remove unused _prom_envp and prom_argc macro.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
arch/mips/fw/arc/init.c | 3 +--
arch/mips/include/asm/sgialib.h | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/mips/fw/arc/init.c b/arch/mips/fw/arc/init.c
index 4ac6466a8872..c713292462aa 100644
--- a/arch/mips/fw/arc/init.c
+++ b/arch/mips/fw/arc/init.c
@@ -19,7 +19,7 @@
/* Master romvec interface. */
struct linux_romvec *romvec;
int prom_argc;
-LONG *_prom_argv, *_prom_envp;
+LONG *_prom_argv;
#if defined(CONFIG_64BIT) && defined(CONFIG_FW_ARC32)
/* stack for calling 32bit ARC prom */
@@ -34,7 +34,6 @@ void __init prom_init(void)
prom_argc = fw_arg0;
_prom_argv = (LONG *) fw_arg1;
- _prom_envp = (LONG *) fw_arg2;
if (pb->magic != 0x53435241) {
printk(KERN_CRIT "Aieee, bad prom vector magic %08lx\n",
diff --git a/arch/mips/include/asm/sgialib.h b/arch/mips/include/asm/sgialib.h
index 21d17eb25ed8..40ab4ef0b1dc 100644
--- a/arch/mips/include/asm/sgialib.h
+++ b/arch/mips/include/asm/sgialib.h
@@ -17,12 +17,11 @@
extern struct linux_romvec *romvec;
extern int prom_argc;
-extern LONG *_prom_argv, *_prom_envp;
+extern LONG *_prom_argv;
/* A 32-bit ARC PROM pass arguments and environment as 32-bit pointer.
These macros take care of sign extension. */
#define prom_argv(index) ((char *) (long) _prom_argv[(index)])
-#define prom_argc(index) ((char *) (long) _prom_argc[(index)])
extern int prom_flags;
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/5] MIPS: arc: use function argument for passing argc/argv to prom_init_cmdline
2019-10-22 16:13 [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Thomas Bogendoerfer
2019-10-22 16:13 ` [PATCH 2/5] MIPS: SGI-IP27: move registering of smp ops into IP27 specific code Thomas Bogendoerfer
2019-10-22 16:13 ` [PATCH 3/5] MIPS: arc: remove unused stuff Thomas Bogendoerfer
@ 2019-10-22 16:13 ` Thomas Bogendoerfer
2019-10-22 16:13 ` [PATCH 5/5] MIPS: SGI-IP27: reduce ARC usage to a minimum Thomas Bogendoerfer
2019-10-24 5:02 ` [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Paul Burton
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2019-10-22 16:13 UTC (permalink / raw)
To: Ralf Baechle, Paul Burton, James Hogan, linux-mips, linux-kernel
prom_argc and prom_argv are only used by prom_init_cmdline(), so
we could pass them directly as function argument.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
arch/mips/fw/arc/cmdline.c | 16 +++++++++++-----
arch/mips/fw/arc/init.c | 7 +------
arch/mips/include/asm/sgialib.h | 9 +--------
3 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/arch/mips/fw/arc/cmdline.c b/arch/mips/fw/arc/cmdline.c
index c0122a1dc587..155c5e911723 100644
--- a/arch/mips/fw/arc/cmdline.c
+++ b/arch/mips/fw/arc/cmdline.c
@@ -17,6 +17,12 @@
#undef DEBUG_CMDLINE
+/*
+ * A 32-bit ARC PROM pass arguments and environment as 32-bit pointer.
+ * These macro take care of sign extension.
+ */
+#define prom_argv(index) ((char *) (long)argv[(index)])
+
static char *ignored[] = {
"ConsoleIn=",
"ConsoleOut=",
@@ -32,14 +38,14 @@ static char *used_arc[][2] = {
{ "OSLoadOptions=", "" }
};
-static char * __init move_firmware_args(char* cp)
+static char __init *move_firmware_args(int argc, LONG *argv, char *cp)
{
char *s;
int actr, i;
actr = 1; /* Always ignore argv[0] */
- while (actr < prom_argc) {
+ while (actr < argc) {
for(i = 0; i < ARRAY_SIZE(used_arc); i++) {
int len = strlen(used_arc[i][0]);
@@ -64,7 +70,7 @@ static char * __init move_firmware_args(char* cp)
return cp;
}
-void __init prom_init_cmdline(void)
+void __init prom_init_cmdline(int argc, LONG *argv)
{
char *cp;
int actr, i;
@@ -76,9 +82,9 @@ void __init prom_init_cmdline(void)
* Move ARC variables to the beginning to make sure they can be
* overridden by later arguments.
*/
- cp = move_firmware_args(cp);
+ cp = move_firmware_args(argc, argv, cp);
- while (actr < prom_argc) {
+ while (actr < argc) {
for (i = 0; i < ARRAY_SIZE(ignored); i++) {
int len = strlen(ignored[i]);
diff --git a/arch/mips/fw/arc/init.c b/arch/mips/fw/arc/init.c
index c713292462aa..f9d1dea9b2ca 100644
--- a/arch/mips/fw/arc/init.c
+++ b/arch/mips/fw/arc/init.c
@@ -18,8 +18,6 @@
/* Master romvec interface. */
struct linux_romvec *romvec;
-int prom_argc;
-LONG *_prom_argv;
#if defined(CONFIG_64BIT) && defined(CONFIG_FW_ARC32)
/* stack for calling 32bit ARC prom */
@@ -32,9 +30,6 @@ void __init prom_init(void)
romvec = ROMVECTOR;
- prom_argc = fw_arg0;
- _prom_argv = (LONG *) fw_arg1;
-
if (pb->magic != 0x53435241) {
printk(KERN_CRIT "Aieee, bad prom vector magic %08lx\n",
(unsigned long) pb->magic);
@@ -42,7 +37,7 @@ void __init prom_init(void)
;
}
- prom_init_cmdline();
+ prom_init_cmdline(fw_arg0, (LONG *)fw_arg1);
prom_identify_arch();
printk(KERN_INFO "PROMLIB: ARC firmware Version %d Revision %d\n",
pb->ver, pb->rev);
diff --git a/arch/mips/include/asm/sgialib.h b/arch/mips/include/asm/sgialib.h
index 40ab4ef0b1dc..80f900417f7e 100644
--- a/arch/mips/include/asm/sgialib.h
+++ b/arch/mips/include/asm/sgialib.h
@@ -15,13 +15,6 @@
#include <asm/sgiarcs.h>
extern struct linux_romvec *romvec;
-extern int prom_argc;
-
-extern LONG *_prom_argv;
-
-/* A 32-bit ARC PROM pass arguments and environment as 32-bit pointer.
- These macros take care of sign extension. */
-#define prom_argv(index) ((char *) (long) _prom_argv[(index)])
extern int prom_flags;
@@ -55,7 +48,7 @@ extern void prom_identify_arch(void);
extern PCHAR ArcGetEnvironmentVariable(PCHAR name);
/* ARCS command line parsing. */
-extern void prom_init_cmdline(void);
+extern void prom_init_cmdline(int argc, LONG *argv);
/* File operations. */
extern LONG ArcRead(ULONG fd, PVOID buf, ULONG num, PULONG cnt);
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/5] MIPS: SGI-IP27: reduce ARC usage to a minimum
2019-10-22 16:13 [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Thomas Bogendoerfer
` (2 preceding siblings ...)
2019-10-22 16:13 ` [PATCH 4/5] MIPS: arc: use function argument for passing argc/argv to prom_init_cmdline Thomas Bogendoerfer
@ 2019-10-22 16:13 ` Thomas Bogendoerfer
2019-10-24 5:02 ` [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Paul Burton
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Bogendoerfer @ 2019-10-22 16:13 UTC (permalink / raw)
To: Ralf Baechle, Paul Burton, James Hogan, linux-mips, linux-kernel
IP27 uses ARC prom only for parsing prom arguments and has a hack
for IP27 to make the ARC code behave. By introducing config symbol
ARC_CMDLINE_ONLY IP27 only drags in ARC cmdline parsing and does
everything else in IP27 specific code.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
arch/mips/Kconfig | 4 ++++
arch/mips/fw/arc/Makefile | 4 ++++
arch/mips/fw/arc/identify.c | 10 ----------
arch/mips/sgi-ip27/ip27-init.c | 14 ++++++++++++++
4 files changed, 22 insertions(+), 10 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 2ef3129cc4ad..376d0ec0d1d6 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -674,6 +674,7 @@ config SGI_IP27
select ARCH_SPARSEMEM_ENABLE
select FW_ARC
select FW_ARC64
+ select ARC_CMDLINE_ONLY
select BOOT_ELF64
select DEFAULT_SGI_PARTITION
select SYS_HAS_EARLY_PRINTK
@@ -1377,6 +1378,9 @@ config MIPS_L1_CACHE_SHIFT
config HAVE_STD_PC_SERIAL_PORT
bool
+config ARC_CMDLINE_ONLY
+ bool
+
config ARC_CONSOLE
bool "ARC console support"
depends on SGI_IP22 || SGI_IP28 || (SNI_RM && CPU_LITTLE_ENDIAN)
diff --git a/arch/mips/fw/arc/Makefile b/arch/mips/fw/arc/Makefile
index 3cc82d7fe548..64d685efcc77 100644
--- a/arch/mips/fw/arc/Makefile
+++ b/arch/mips/fw/arc/Makefile
@@ -3,8 +3,12 @@
# Makefile for the ARC prom monitor library routines under Linux.
#
+ifdef CONFIG_ARC_CMDLINE_ONLY
+lib-y += cmdline.o
+else
lib-y += cmdline.o env.o file.o identify.o init.o \
misc.o
+endif
lib-$(CONFIG_ARC_MEMORY) += memory.o
lib-$(CONFIG_ARC_CONSOLE) += arc_con.o
diff --git a/arch/mips/fw/arc/identify.c b/arch/mips/fw/arc/identify.c
index 7530c7b2fd39..5527e0f54079 100644
--- a/arch/mips/fw/arc/identify.c
+++ b/arch/mips/fw/arc/identify.c
@@ -31,10 +31,6 @@ static struct smatch mach_table[] = {
.arcname = "SGI-IP22",
.liname = "SGI Indy",
.flags = PROM_FLAG_ARCS,
- }, {
- .arcname = "SGI-IP27",
- .liname = "SGI Origin",
- .flags = PROM_FLAG_ARCS,
}, {
.arcname = "SGI-IP28",
.liname = "SGI IP28",
@@ -103,13 +99,7 @@ void __init prom_identify_arch(void)
*/
p = ArcGetChild(PROM_NULL_COMPONENT);
if (p == NULL) {
-#ifdef CONFIG_SGI_IP27
- /* IP27 PROM misbehaves, seems to not implement ARC
- GetChild(). So we just assume it's an IP27. */
- iname = "SGI-IP27";
-#else
iname = "Unknown";
-#endif
} else
iname = (char *) (long) p->iname;
diff --git a/arch/mips/sgi-ip27/ip27-init.c b/arch/mips/sgi-ip27/ip27-init.c
index d160fb219d6d..971aa0d5d534 100644
--- a/arch/mips/sgi-ip27/ip27-init.c
+++ b/arch/mips/sgi-ip27/ip27-init.c
@@ -13,9 +13,11 @@
#include <linux/mm.h>
#include <linux/export.h>
#include <linux/cpumask.h>
+#include <asm/bootinfo.h>
#include <asm/cpu.h>
#include <asm/io.h>
#include <asm/pgtable.h>
+#include <asm/sgialib.h>
#include <asm/time.h>
#include <asm/sn/types.h>
#include <asm/sn/sn0/addrs.h>
@@ -160,3 +162,15 @@ void __init plat_mem_setup(void)
ioport_resource.end = ~0UL;
set_io_port_base(IO_BASE);
}
+
+const char *get_system_type(void)
+{
+ return "SGI Origin";
+}
+
+void __init prom_init(void)
+{
+ prom_init_cmdline(fw_arg0, (LONG *)fw_arg1);
+ prom_meminit();
+}
+
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file
2019-10-22 16:13 [PATCH 1/5] MIPS: SGI-IP27: collect externs in new header file Thomas Bogendoerfer
` (3 preceding siblings ...)
2019-10-22 16:13 ` [PATCH 5/5] MIPS: SGI-IP27: reduce ARC usage to a minimum Thomas Bogendoerfer
@ 2019-10-24 5:02 ` Paul Burton
4 siblings, 0 replies; 6+ messages in thread
From: Paul Burton @ 2019-10-24 5:02 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Ralf Baechle, Paul Burton, James Hogan, linux-mips, linux-kernel,
linux-mips
Hello,
Thomas Bogendoerfer wrote:
> IP27 code has a few externs distributed over .c files. Collect them
> together into one commcon header file.
Series applied to mips-next.
> MIPS: SGI-IP27: collect externs in new header file
> commit 249be5633cdb
> https://git.kernel.org/mips/c/249be5633cdb
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
>
> MIPS: SGI-IP27: move registering of smp ops into IP27 specific code
> commit c823f4160978
> https://git.kernel.org/mips/c/c823f4160978
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
>
> MIPS: arc: remove unused stuff
> commit cbd09241dd9d
> https://git.kernel.org/mips/c/cbd09241dd9d
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
>
> MIPS: arc: use function argument for passing argc/argv to prom_init_cmdline
> commit 7b16831d1eb1
> https://git.kernel.org/mips/c/7b16831d1eb1
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
>
> MIPS: SGI-IP27: reduce ARC usage to a minimum
> commit e942242784d0
> https://git.kernel.org/mips/c/e942242784d0
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paulburton@kernel.org to report it. ]
^ permalink raw reply [flat|nested] 6+ messages in thread