* [PATCH -next] staging: comedi: remove unused variable 'route_table_size'
@ 2019-10-23 7:52 YueHaibing
2019-10-23 9:07 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-23 7:52 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, yuehaibing; +Cc: devel, linux-kernel
drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
route_table_size defined but not used [-Wunused-const-variable=]
It is never used since introduction.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/comedi/drivers/ni_routes.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_routes.c b/drivers/staging/comedi/drivers/ni_routes.c
index eb61494..673d732 100644
--- a/drivers/staging/comedi/drivers/ni_routes.c
+++ b/drivers/staging/comedi/drivers/ni_routes.c
@@ -49,8 +49,6 @@
/* Helper for accessing data. */
#define RVi(table, src, dest) ((table)[(dest) * NI_NUM_NAMES + (src)])
-static const size_t route_table_size = NI_NUM_NAMES * NI_NUM_NAMES;
-
/*
* Find the proper route_values and ni_device_routes tables for this particular
* device.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] staging: comedi: remove unused variable 'route_table_size'
2019-10-23 7:52 [PATCH -next] staging: comedi: remove unused variable 'route_table_size' YueHaibing
@ 2019-10-23 9:07 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2019-10-23 9:07 UTC (permalink / raw)
To: YueHaibing, hsweeten, gregkh; +Cc: devel, linux-kernel
On 23/10/2019 08:52, YueHaibing wrote:
> drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
> route_table_size defined but not used [-Wunused-const-variable=]
>
> It is never used since introduction.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/comedi/drivers/ni_routes.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_routes.c b/drivers/staging/comedi/drivers/ni_routes.c
> index eb61494..673d732 100644
> --- a/drivers/staging/comedi/drivers/ni_routes.c
> +++ b/drivers/staging/comedi/drivers/ni_routes.c
> @@ -49,8 +49,6 @@
> /* Helper for accessing data. */
> #define RVi(table, src, dest) ((table)[(dest) * NI_NUM_NAMES + (src)])
>
> -static const size_t route_table_size = NI_NUM_NAMES * NI_NUM_NAMES;
> -
> /*
> * Find the proper route_values and ni_device_routes tables for this particular
> * device.
>
Looks good, thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-23 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 7:52 [PATCH -next] staging: comedi: remove unused variable 'route_table_size' YueHaibing
2019-10-23 9:07 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).