* [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree
@ 2019-10-23 11:11 Wambui Karuga
2019-10-24 12:12 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Wambui Karuga @ 2019-10-23 11:11 UTC (permalink / raw)
To: dri-devel; +Cc: linux-kernel, ck.hu, p.zabel, airlied, daniel
Remove unnecessary casts to pointer types passed to kfree.
Issue detected by coccinelle:
@@
type t1;
expression *e;
@@
-kfree((t1 *)e);
+kfree(e);
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index ca672f1d140d..b04a3c2b111e 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -271,7 +271,7 @@ void *mtk_drm_gem_prime_vmap(struct drm_gem_object *obj)
pgprot_writecombine(PAGE_KERNEL));
out:
- kfree((void *)sgt);
+ kfree(sgt);
return mtk_gem->kvaddr;
}
@@ -285,5 +285,5 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
vunmap(vaddr);
mtk_gem->kvaddr = 0;
- kfree((void *)mtk_gem->pages);
+ kfree(mtk_gem->pages);
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree
2019-10-23 11:11 [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree Wambui Karuga
@ 2019-10-24 12:12 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2019-10-24 12:12 UTC (permalink / raw)
To: Wambui Karuga; +Cc: dri-devel, linux-kernel, ck.hu, p.zabel, airlied, daniel
On Wed, Oct 23, 2019 at 02:11:07PM +0300, Wambui Karuga wrote:
> Remove unnecessary casts to pointer types passed to kfree.
> Issue detected by coccinelle:
> @@
> type t1;
> expression *e;
> @@
>
> -kfree((t1 *)e);
> +kfree(e);
>
> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Applied to drm-misc-next, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index ca672f1d140d..b04a3c2b111e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -271,7 +271,7 @@ void *mtk_drm_gem_prime_vmap(struct drm_gem_object *obj)
> pgprot_writecombine(PAGE_KERNEL));
>
> out:
> - kfree((void *)sgt);
> + kfree(sgt);
>
> return mtk_gem->kvaddr;
> }
> @@ -285,5 +285,5 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> vunmap(vaddr);
> mtk_gem->kvaddr = 0;
> - kfree((void *)mtk_gem->pages);
> + kfree(mtk_gem->pages);
> }
> --
> 2.23.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-24 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 11:11 [Outreachy][PATCH] drm/mediatek: remove cast to pointers passed to kfree Wambui Karuga
2019-10-24 12:12 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).