* [PATCH -next] mtd: rawnand: cadence: Remove dev_err() on platform_get_irq() failure
@ 2019-10-23 13:57 YueHaibing
0 siblings, 0 replies; only message in thread
From: YueHaibing @ 2019-10-23 13:57 UTC (permalink / raw)
To: piotrs, miquel.raynal, richard, dwmw2, computersforpeace, vigneshr
Cc: linux-mtd, linux-kernel, YueHaibing
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mtd/nand/raw/cadence-nand-controller.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
index 91dabff..5f07e8e 100644
--- a/drivers/mtd/nand/raw/cadence-nand-controller.c
+++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
@@ -2961,10 +2961,8 @@ static int cadence_nand_dt_probe(struct platform_device *ofdev)
cdns_ctrl->dev = &ofdev->dev;
cdns_ctrl->irq = platform_get_irq(ofdev, 0);
- if (cdns_ctrl->irq < 0) {
- dev_err(&ofdev->dev, "no irq defined\n");
+ if (cdns_ctrl->irq < 0)
return cdns_ctrl->irq;
- }
dev_info(cdns_ctrl->dev, "IRQ: nr %d\n", cdns_ctrl->irq);
cdns_ctrl->reg = devm_platform_ioremap_resource(ofdev, 0);
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-23 13:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 13:57 [PATCH -next] mtd: rawnand: cadence: Remove dev_err() on platform_get_irq() failure YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).