From: Florian Westphal <fw@strlen.de>
To: praveen chaudhary <praveen5582@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
davem@davemloft.net, kadlec@netfilter.org, pablo@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhenggen Xu <zxu@linkedin.com>,
Andy Stracner <astracner@linkedin.com>
Subject: Re: [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet.
Date: Thu, 24 Oct 2019 03:12:18 +0200 [thread overview]
Message-ID: <20191024011218.GT25052@breakpoint.cc> (raw)
In-Reply-To: <CAJ_cd4qHM3kqz24Uywpyyz0mPz7axiNZk0Q385ROd4O8XZ11fA@mail.gmail.com>
praveen chaudhary <praveen5582@gmail.com> wrote:
> inet_proto_csum_replace16 is called from many places, whereas this fix is
> applicable only for nf_nat_ipv6_csum_update. where we need to update
> skb->csum for ipv6 src/dst address change.
Under which circumstances does inet_proto_csum_replace16 upate
skb->csum correctly?
> So, I added a new function. Basically, I used a safe approach to fix it,
> without impacting other cases. Let me know other options, I am open to
> suggestions.
You seem to imply inet_proto_csum_replace16 is fine and only broken for ipv6
nat.
next prev parent reply other threads:[~2019-10-24 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 19:02 [PATCH] Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet Praveen Chaudhary
2019-10-23 19:02 ` [PATCH] [netfilter]: " Praveen Chaudhary
2019-10-23 19:33 ` Florian Westphal
2019-10-23 20:56 ` [PATCH] [netfilter]: Fix skb->csum calculation when netfilter Praveen Chaudhary
[not found] ` <CAJ_cd4qHM3kqz24Uywpyyz0mPz7axiNZk0Q385ROd4O8XZ11fA@mail.gmail.com>
2019-10-24 1:12 ` Florian Westphal [this message]
2019-10-24 5:19 ` Praveen Chaudhary
2019-10-28 22:27 [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet Praveen Chaudhary
2019-10-28 22:27 ` Praveen Chaudhary
2019-10-29 16:09 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024011218.GT25052@breakpoint.cc \
--to=fw@strlen.de \
--cc=astracner@linkedin.com \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=praveen5582@gmail.com \
--cc=zxu@linkedin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).