linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Praveen Chaudhary <praveen5582@gmail.com>
Cc: davem@davemloft.net, fw@strlen.de, kadlec@netfilter.org,
	pablo@netfilter.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Zhenggen Xu <zxu@linkedin.com>,
	Andy Stracner <astracner@linkedin.com>
Subject: Re: [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet.
Date: Tue, 29 Oct 2019 17:09:23 +0100	[thread overview]
Message-ID: <20191029160923.GB876@breakpoint.cc> (raw)
In-Reply-To: <1572301675-5403-2-git-send-email-pchaudhary@linkedin.com>

Praveen Chaudhary <praveen5582@gmail.com> wrote:
> No need to update skb->csum in function inet_proto_csum_replace16(),
> even if skb->ip_summed == CHECKSUM_COMPLETE, because change in L4
> header checksum field and change in IPV6 header cancels each other
> for skb->csum calculation.

Can you resend this and submit this patch to
netfilter-devel@vger.kernel.org?

You may add:
Reviewed-by: Florian Westphal <fw@strlen.de>

  reply	other threads:[~2019-10-29 16:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 22:27 [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet Praveen Chaudhary
2019-10-28 22:27 ` Praveen Chaudhary
2019-10-29 16:09   ` Florian Westphal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-10-23 19:02 [PATCH] " Praveen Chaudhary
2019-10-23 19:02 ` [PATCH] [netfilter]: " Praveen Chaudhary
2019-10-23 19:33   ` Florian Westphal
     [not found]     ` <CAJ_cd4qHM3kqz24Uywpyyz0mPz7axiNZk0Q385ROd4O8XZ11fA@mail.gmail.com>
2019-10-24  1:12       ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029160923.GB876@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=astracner@linkedin.com \
    --cc=davem@davemloft.net \
    --cc=kadlec@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=praveen5582@gmail.com \
    --cc=zxu@linkedin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).