From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org,
jank@cadence.com, srinivas.kandagatla@linaro.org,
slawomir.blauciak@intel.com,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH] soundwire: intel: fix PDI/stream mapping for Bulk
Date: Thu, 24 Oct 2019 16:53:56 +0530 [thread overview]
Message-ID: <20191024112356.GA2620@vkoul-mobl> (raw)
In-Reply-To: <20191022232948.17156-1-pierre-louis.bossart@linux.intel.com>
On 22-10-19, 18:29, Pierre-Louis Bossart wrote:
> The previous formula is incorrect for PDI0/1, the mapping is not
> linear but has a discontinuity between PDI1 and PDI2.
>
> This change has no effect on PCM PDIs (same mapping).
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/intel.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index b403ccc832b6..c984261fcc33 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -480,7 +480,10 @@ intel_pdi_shim_configure(struct sdw_intel *sdw, struct sdw_cdns_pdi *pdi)
> unsigned int link_id = sdw->instance;
> int pdi_conf = 0;
>
> - pdi->intel_alh_id = (link_id * 16) + pdi->num + 5;
> + /* the Bulk and PCM streams are not contiguous */
> + pdi->intel_alh_id = (link_id * 16) + pdi->num + 3;
> + if (pdi->num >= 2)
> + pdi->intel_alh_id += 2;
>
> /*
> * Program stream parameters to stream SHIM register
> @@ -509,7 +512,10 @@ intel_pdi_alh_configure(struct sdw_intel *sdw, struct sdw_cdns_pdi *pdi)
> unsigned int link_id = sdw->instance;
> unsigned int conf;
>
> - pdi->intel_alh_id = (link_id * 16) + pdi->num + 5;
> + /* the Bulk and PCM streams are not contiguous */
> + pdi->intel_alh_id = (link_id * 16) + pdi->num + 3;
> + if (pdi->num >= 2)
> + pdi->intel_alh_id += 2;
The change is repeated so how about:
intel_pdi_update_alh() or similar which does this rather than
repeat the pattern
>
> /* Program Stream config ALH register */
> conf = intel_readl(alh, SDW_ALH_STRMZCFG(pdi->intel_alh_id));
> --
> 2.20.1
--
~Vinod
next prev parent reply other threads:[~2019-10-24 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 23:29 [PATCH] soundwire: intel: fix PDI/stream mapping for Bulk Pierre-Louis Bossart
2019-10-24 11:23 ` Vinod Koul [this message]
2019-10-24 12:37 ` [alsa-devel] " Pierre-Louis Bossart
2019-11-09 11:15 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024112356.GA2620@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).