From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH] soundwire: intel: fix PDI/stream mapping for Bulk
Date: Thu, 24 Oct 2019 07:37:13 -0500 [thread overview]
Message-ID: <6bcfe0bc-5b8e-fb23-f221-b82f2201feb9@linux.intel.com> (raw)
In-Reply-To: <20191024112356.GA2620@vkoul-mobl>
On 10/24/19 6:23 AM, Vinod Koul wrote:
> On 22-10-19, 18:29, Pierre-Louis Bossart wrote:
>> The previous formula is incorrect for PDI0/1, the mapping is not
>> linear but has a discontinuity between PDI1 and PDI2.
>>
>> This change has no effect on PCM PDIs (same mapping).
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>> drivers/soundwire/intel.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
>> index b403ccc832b6..c984261fcc33 100644
>> --- a/drivers/soundwire/intel.c
>> +++ b/drivers/soundwire/intel.c
>> @@ -480,7 +480,10 @@ intel_pdi_shim_configure(struct sdw_intel *sdw, struct sdw_cdns_pdi *pdi)
>> unsigned int link_id = sdw->instance;
>> int pdi_conf = 0;
>>
>> - pdi->intel_alh_id = (link_id * 16) + pdi->num + 5;
>> + /* the Bulk and PCM streams are not contiguous */
>> + pdi->intel_alh_id = (link_id * 16) + pdi->num + 3;
>> + if (pdi->num >= 2)
>> + pdi->intel_alh_id += 2;
>>
>> /*
>> * Program stream parameters to stream SHIM register
>> @@ -509,7 +512,10 @@ intel_pdi_alh_configure(struct sdw_intel *sdw, struct sdw_cdns_pdi *pdi)
>> unsigned int link_id = sdw->instance;
>> unsigned int conf;
>>
>> - pdi->intel_alh_id = (link_id * 16) + pdi->num + 5;
>> + /* the Bulk and PCM streams are not contiguous */
>> + pdi->intel_alh_id = (link_id * 16) + pdi->num + 3;
>> + if (pdi->num >= 2)
>> + pdi->intel_alh_id += 2;
>
> The change is repeated so how about:
>
> intel_pdi_update_alh() or similar which does this rather than
> repeat the pattern
The initial code was also repeated by the initial contributors, this
patch does not refactor the code but corrects an invalid mapping. We
will do this refactoring at a later point, when we add the clock-stop mode.
>
>>
>> /* Program Stream config ALH register */
>> conf = intel_readl(alh, SDW_ALH_STRMZCFG(pdi->intel_alh_id));
>> --
>> 2.20.1
>
next prev parent reply other threads:[~2019-10-24 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 23:29 [PATCH] soundwire: intel: fix PDI/stream mapping for Bulk Pierre-Louis Bossart
2019-10-24 11:23 ` Vinod Koul
2019-10-24 12:37 ` Pierre-Louis Bossart [this message]
2019-11-09 11:15 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bcfe0bc-5b8e-fb23-f221-b82f2201feb9@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).