* [PATCH] net: fec: remove redundant assignment to pointer bdp
@ 2019-10-25 17:22 Colin King
2019-10-26 4:54 ` [EXT] " Andy Duan
2019-10-29 19:09 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-10-25 17:22 UTC (permalink / raw)
To: Fugang Duan, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer bdp is being assigned with a value that is never
read, so the assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/freescale/fec_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index d4d4c72adf49..608196bdd892 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct net_device *ndev)
for (q = 0; q < fep->num_tx_queues; q++) {
txq = fep->tx_queue[q];
- bdp = txq->bd.base;
for (i = 0; i < txq->bd.ring_size; i++) {
kfree(txq->tx_bounce[i]);
txq->tx_bounce[i] = NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] net: fec: remove redundant assignment to pointer bdp
2019-10-25 17:22 [PATCH] net: fec: remove redundant assignment to pointer bdp Colin King
@ 2019-10-26 4:54 ` Andy Duan
2019-10-29 19:09 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andy Duan @ 2019-10-26 4:54 UTC (permalink / raw)
To: Colin King, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com> Sent: Saturday, October 26, 2019 1:23 AM
> The pointer bdp is being assigned with a value that is never read, so the
> assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks.
Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d4d4c72adf49..608196bdd892 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct
> net_device *ndev)
>
> for (q = 0; q < fep->num_tx_queues; q++) {
> txq = fep->tx_queue[q];
> - bdp = txq->bd.base;
> for (i = 0; i < txq->bd.ring_size; i++) {
> kfree(txq->tx_bounce[i]);
> txq->tx_bounce[i] = NULL;
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fec: remove redundant assignment to pointer bdp
2019-10-25 17:22 [PATCH] net: fec: remove redundant assignment to pointer bdp Colin King
2019-10-26 4:54 ` [EXT] " Andy Duan
@ 2019-10-29 19:09 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-29 19:09 UTC (permalink / raw)
To: colin.king; +Cc: fugang.duan, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 25 Oct 2019 18:22:55 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer bdp is being assigned with a value that is never
> read, so the assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 17:22 [PATCH] net: fec: remove redundant assignment to pointer bdp Colin King
2019-10-26 4:54 ` [EXT] " Andy Duan
2019-10-29 19:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).