From: Jean Delvare <jdelvare@suse.de>
To: Rain Wang <Rain_Wang@Jabil.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] lm75: add lm75b detection
Date: Mon, 28 Oct 2019 10:46:18 +0100 [thread overview]
Message-ID: <20191028104618.5f21af38@endymion> (raw)
In-Reply-To: <7a2ddf42-8bbe-59e0-dae8-85b184ea0da0@roeck-us.net>
On Sun, 27 Oct 2019 16:03:39 -0700, Guenter Roeck wrote:
> On 10/26/19 1:10 AM, Rain Wang wrote:
> > The National Semiconductor LM75B is very similar as the
> > LM75A, but it has no ID byte register 7, and unused registers
> > return 0xff rather than the last read value like LM75A.
Please send hwmon-related patches to the linux-hwmon list.
> > Signed-off-by: Rain Wang <rain_wang@jabil.com>
>
> I am quite hesitant to touch the detect function for this chip.
> Each addition increases the risk for false positives. What is the
> use case ?
I'm positively certain I don't want this. Ideally there should be no
detection at all for device without ID registers. The only reason there
are some occurrences of that is because there were no way to explicitly
instantiate I2C devices back then, and we have left the detection in
place to avoid perceived regressions. But today there are plenty of
ways to explicitly instantiate your I2C devices so there are no excuses
for more crappy detect functions. Ideally we would even get rid of
existing ones at some point in the future.
This patch is bad anyway as it only changes the device name without
implementing proper support for the LM75B.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-10-28 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 8:10 [PATCH] lm75: add lm75b detection Rain Wang
2019-10-27 23:03 ` Guenter Roeck
2019-10-28 9:46 ` Jean Delvare [this message]
2019-10-29 14:02 ` Guenter Roeck
2019-11-07 6:18 ` Rain Wang
2019-10-28 11:28 Rain Wang
2019-10-28 11:37 Rain Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028104618.5f21af38@endymion \
--to=jdelvare@suse.de \
--cc=Rain_Wang@Jabil.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).