From: Rain Wang <Rain_Wang@Jabil.com>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH] lm75: add lm75b detection
Date: Thu, 7 Nov 2019 06:18:01 +0000 [thread overview]
Message-ID: <MN2PR02MB67038B3F8DF699BD0C462C458D780@MN2PR02MB6703.namprd02.prod.outlook.com> (raw)
In-Reply-To: <82a0b331-daa0-af9a-a7d0-0f1b3246ea49@roeck-us.net>
Sorry for my late reply,
>FWIW, I don't think there is anything to implement; I don't see any
>differences in functionality.
Yes, no functional difference but the detection
>I am much more concerned about weakening the already weak detection even further:
>As written, each chip with register 0x07 != 0xa1 will be identified as LM75B.
>Even if that was strengthened to actually check if the register value is 0xff,
>we have no idea what other vendors might implement in those registers. it would
>most certainly mis-identify LM75C as LM75B. Not that it really matters if
>the chip _is_ a LM75C, but who knows if other chips fit that identification
>pattern.
Yes, that's also my concern on the code of detection. I don't have any other sensors as
LM75C to try, so thinking maybe some other guys can help extend it if needed in future.
>Overall, my suggestion is to add a small startup script to affected systems
>to instantiate the chip directly, and avoid weakening the detect function.
Understood, we can have the instantiating script but just don't want limit the detection.
Thanks!
next prev parent reply other threads:[~2019-11-07 6:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 8:10 [PATCH] lm75: add lm75b detection Rain Wang
2019-10-27 23:03 ` Guenter Roeck
2019-10-28 9:46 ` Jean Delvare
2019-10-29 14:02 ` Guenter Roeck
2019-11-07 6:18 ` Rain Wang [this message]
2019-10-28 11:28 Rain Wang
2019-10-28 11:37 Rain Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR02MB67038B3F8DF699BD0C462C458D780@MN2PR02MB6703.namprd02.prod.outlook.com \
--to=rain_wang@jabil.com \
--cc=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).