From: Maxime Ripard <mripard@kernel.org>
To: Ondrej Jirman <megous@megous.com>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend
Date: Tue, 29 Oct 2019 08:44:49 +0100 [thread overview]
Message-ID: <20191029074449.jx2acknfds2idyjt@hendrix> (raw)
In-Reply-To: <20191028215859.3467317-1-megous@megous.com>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On Mon, Oct 28, 2019 at 10:58:58PM +0100, Ondrej Jirman wrote:
> Without enabling keep-power-in-suspend, we can't wake the device
> up using WOL packet, and the log is flooded with these messages
> on resume:
>
> sunxi-mmc 1c10000.mmc: send stop command failed
> sunxi-mmc 1c10000.mmc: data error, sending stop command
> sunxi-mmc 1c10000.mmc: send stop command failed
> sunxi-mmc 1c10000.mmc: data error, sending stop command
>
> So to make the WiFi really a wakeup-source, we need to keep it powered
> during suspend.
>
> Fixes: 0e23372080def7 ("arm: dts: sun8i: Add the TBS A711 tablet devicetree")
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks!
(I don't have my ssh key with me, so it might take a while before it's
pushed...)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2019-10-29 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 21:58 [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend Ondrej Jirman
2019-10-29 7:44 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029074449.jx2acknfds2idyjt@hendrix \
--to=mripard@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).