* [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend
@ 2019-10-28 21:58 Ondrej Jirman
2019-10-29 7:44 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Jirman @ 2019-10-28 21:58 UTC (permalink / raw)
To: linux-sunxi
Cc: Ondrej Jirman, Rob Herring, Mark Rutland, Maxime Ripard,
Chen-Yu Tsai,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
Without enabling keep-power-in-suspend, we can't wake the device
up using WOL packet, and the log is flooded with these messages
on resume:
sunxi-mmc 1c10000.mmc: send stop command failed
sunxi-mmc 1c10000.mmc: data error, sending stop command
sunxi-mmc 1c10000.mmc: send stop command failed
sunxi-mmc 1c10000.mmc: data error, sending stop command
So to make the WiFi really a wakeup-source, we need to keep it powered
during suspend.
Fixes: 0e23372080def7 ("arm: dts: sun8i: Add the TBS A711 tablet devicetree")
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
index 43b21599898e..5b8c9c24350b 100644
--- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -311,6 +311,7 @@
vqmmc-supply = <®_dldo1>;
non-removable;
wakeup-source;
+ keep-power-in-suspend;
status = "okay";
brcmf: wifi@1 {
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend
2019-10-28 21:58 [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend Ondrej Jirman
@ 2019-10-29 7:44 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2019-10-29 7:44 UTC (permalink / raw)
To: Ondrej Jirman
Cc: linux-sunxi, Rob Herring, Mark Rutland, Chen-Yu Tsai,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Allwinner sunXi SoC support, open list
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On Mon, Oct 28, 2019 at 10:58:58PM +0100, Ondrej Jirman wrote:
> Without enabling keep-power-in-suspend, we can't wake the device
> up using WOL packet, and the log is flooded with these messages
> on resume:
>
> sunxi-mmc 1c10000.mmc: send stop command failed
> sunxi-mmc 1c10000.mmc: data error, sending stop command
> sunxi-mmc 1c10000.mmc: send stop command failed
> sunxi-mmc 1c10000.mmc: data error, sending stop command
>
> So to make the WiFi really a wakeup-source, we need to keep it powered
> during suspend.
>
> Fixes: 0e23372080def7 ("arm: dts: sun8i: Add the TBS A711 tablet devicetree")
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks!
(I don't have my ssh key with me, so it might take a while before it's
pushed...)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-29 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 21:58 [PATCH] ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend Ondrej Jirman
2019-10-29 7:44 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).