* [PATCH v2 2/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace)
2019-10-29 9:16 [PATCH v2 1/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (missing blank line) Chandra Annamaneni
@ 2019-10-29 9:16 ` Chandra Annamaneni
2019-10-29 9:16 ` [PATCH v2 3/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment) Chandra Annamaneni
2019-10-29 9:16 ` [PATCH v2 4/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis) Chandra Annamaneni
2 siblings, 0 replies; 4+ messages in thread
From: Chandra Annamaneni @ 2019-10-29 9:16 UTC (permalink / raw)
To: gregkh
Cc: gneukum1, dan.carpenter, michael.scheiderer, fabian.krueger,
chandra627, simon, devel, linux-kernel
Resolved: ERROR: else should follow close brace '}'
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging. The previous version of this patch had the wrong
description and subject.
drivers/staging/kpc2000/kpc2000_spi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 5712a88c8788..929136cdc3e1 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -226,8 +226,7 @@ kp_spi_txrx_pio(struct spi_device *spidev, struct spi_transfer *transfer)
kp_spi_write_reg(cs, KP_SPI_REG_TXDATA, val);
processed++;
}
- }
- else if (rx) {
+ } else if (rx) {
for (i = 0 ; i < c ; i++) {
char test = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment)
2019-10-29 9:16 [PATCH v2 1/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (missing blank line) Chandra Annamaneni
2019-10-29 9:16 ` [PATCH v2 2/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace) Chandra Annamaneni
@ 2019-10-29 9:16 ` Chandra Annamaneni
2019-10-29 9:16 ` [PATCH v2 4/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis) Chandra Annamaneni
2 siblings, 0 replies; 4+ messages in thread
From: Chandra Annamaneni @ 2019-10-29 9:16 UTC (permalink / raw)
To: gregkh
Cc: gneukum1, dan.carpenter, michael.scheiderer, fabian.krueger,
chandra627, simon, devel, linux-kernel
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 929136cdc3e1..24de8d63f504 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -313,19 +313,19 @@ kp_spi_transfer_one_message(struct spi_master *master, struct spi_message *m)
if (transfer->speed_hz > KP_SPI_CLK ||
(len && !(rx_buf || tx_buf))) {
dev_dbg(kpspi->dev, " transfer: %d Hz, %d %s%s, %d bpw\n",
- transfer->speed_hz,
- len,
- tx_buf ? "tx" : "",
- rx_buf ? "rx" : "",
- transfer->bits_per_word);
+ transfer->speed_hz,
+ len,
+ tx_buf ? "tx" : "",
+ rx_buf ? "rx" : "",
+ transfer->bits_per_word);
dev_dbg(kpspi->dev, " transfer -EINVAL\n");
return -EINVAL;
}
if (transfer->speed_hz &&
transfer->speed_hz < (KP_SPI_CLK >> 15)) {
dev_dbg(kpspi->dev, "speed_hz %d below minimum %d Hz\n",
- transfer->speed_hz,
- KP_SPI_CLK >> 15);
+ transfer->speed_hz,
+ KP_SPI_CLK >> 15);
dev_dbg(kpspi->dev, " speed_hz -EINVAL\n");
return -EINVAL;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 4/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis)
2019-10-29 9:16 [PATCH v2 1/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (missing blank line) Chandra Annamaneni
2019-10-29 9:16 ` [PATCH v2 2/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace) Chandra Annamaneni
2019-10-29 9:16 ` [PATCH v2 3/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment) Chandra Annamaneni
@ 2019-10-29 9:16 ` Chandra Annamaneni
2 siblings, 0 replies; 4+ messages in thread
From: Chandra Annamaneni @ 2019-10-29 9:16 UTC (permalink / raw)
To: gregkh
Cc: gneukum1, dan.carpenter, michael.scheiderer, fabian.krueger,
chandra627, simon, devel, linux-kernel
Resolved: CHECK: Unnecessary parentheses around table[i]
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
---
Previous versions of these patches were not split into different
patches, did not have different patch numbers and did not have the
keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 24de8d63f504..8becf972af9c 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -476,7 +476,7 @@ kp_spi_probe(struct platform_device *pldev)
/* register the slave boards */
#define NEW_SPI_DEVICE_FROM_BOARD_INFO_TABLE(table) \
for (i = 0 ; i < ARRAY_SIZE(table) ; i++) { \
- spi_new_device(master, &(table[i])); \
+ spi_new_device(master, &table[i]); \
}
switch ((drvdata->card_id & 0xFFFF0000) >> 16) {
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread