linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtlwifi: rtl8821ae: phy.c: Drop condition with no effect
@ 2019-10-29 13:16 Saurav Girepunje
  2019-10-31  8:09 ` [PATCH] rtlwifi: rtl8821ae: " Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2019-10-29 13:16 UTC (permalink / raw)
  To: pkshih, kvalo, davem, Larry.Finger, gustavo, colin.king,
	saurav.girepunje, linux-wireless, netdev, linux-kernel
  Cc: saurav.girepunje

As the "else if" and "else" branch body are identical the condition
has no effect. So drop the "else if" condition.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 979e434a4e73..cad560aeb7dd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -3553,8 +3553,6 @@ void rtl8821ae_phy_sw_chnl_callback(struct ieee80211_hw *hw)
 			if (rtlhal->hw_type == HARDWARE_TYPE_RTL8821AE) {
 				if (36 <= channel && channel <= 64)
 					data = 0x114E9;
-				else if (100 <= channel && channel <= 140)
-					data = 0x110E9;
 				else
 					data = 0x110E9;
 				rtl8821ae_phy_set_rf_reg(hw, path, RF_APK,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rtlwifi: rtl8821ae: Drop condition with no effect
  2019-10-29 13:16 [PATCH] rtlwifi: rtl8821ae: phy.c: Drop condition with no effect Saurav Girepunje
@ 2019-10-31  8:09 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-10-31  8:09 UTC (permalink / raw)
  To: Saurav Girepunje
  Cc: pkshih, davem, Larry.Finger, gustavo, colin.king,
	saurav.girepunje, linux-wireless, netdev, linux-kernel,
	saurav.girepunje

Saurav Girepunje <saurav.girepunje@gmail.com> wrote:

> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

4b15f83adaf1 rtlwifi: rtl8821ae: Drop condition with no effect

-- 
https://patchwork.kernel.org/patch/11217859/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-31  8:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 13:16 [PATCH] rtlwifi: rtl8821ae: phy.c: Drop condition with no effect Saurav Girepunje
2019-10-31  8:09 ` [PATCH] rtlwifi: rtl8821ae: " Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).