* [PATCH v2] arm64: cpufeature: Enable Qualcomm Falkor/Kryo errata 1003
@ 2019-10-29 17:15 Bjorn Andersson
2019-10-29 17:39 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2019-10-29 17:15 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, Suzuki K Poulose
Cc: linux-arm-kernel, linux-kernel, linux-arm-msm, stable, Mark Brown
With the introduction of 'cce360b54ce6 ("arm64: capabilities: Filter the
entries based on a given mask")' the Qualcomm Falkor/Kryo errata 1003 is
no long applied.
The result of not applying errata 1003 is that MSM8996 runs into various
RCU stalls and fails to boot most of the times.
Give 1003 a "type" to ensure they are not filtered out in
update_cpu_capabilities().
Fixes: cce360b54ce6 ("arm64: capabilities: Filter the entries based on a given mask")
Cc: stable@vger.kernel.org
Reported-by: Mark Brown <broonie@kernel.org>
Suggested-by: Will Deacon <will@kernel.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes since v1:
- s/ARM64_CPUCAP_SCOPE_LOCAL_CPU/ARM64_CPUCAP_LOCAL_CPU_ERRATUM/
- Dropped 1009 "fix" as it already had a type from ERRATA_MIDR_RANGE_LIST()
arch/arm64/kernel/cpu_errata.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index df9465120e2f..3facd5ca52ed 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -780,6 +780,7 @@ const struct arm64_cpu_capabilities arm64_errata[] = {
{
.desc = "Qualcomm Technologies Falkor/Kryo erratum 1003",
.capability = ARM64_WORKAROUND_QCOM_FALKOR_E1003,
+ .type = ARM64_CPUCAP_LOCAL_CPU_ERRATUM,
.matches = cpucap_multi_entry_cap_matches,
.match_list = qcom_erratum_1003_list,
},
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: cpufeature: Enable Qualcomm Falkor/Kryo errata 1003
2019-10-29 17:15 [PATCH v2] arm64: cpufeature: Enable Qualcomm Falkor/Kryo errata 1003 Bjorn Andersson
@ 2019-10-29 17:39 ` Will Deacon
2019-10-29 17:41 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2019-10-29 17:39 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Catalin Marinas, Suzuki K Poulose, linux-arm-kernel,
linux-kernel, linux-arm-msm, stable, Mark Brown
On Tue, Oct 29, 2019 at 10:15:39AM -0700, Bjorn Andersson wrote:
> With the introduction of 'cce360b54ce6 ("arm64: capabilities: Filter the
> entries based on a given mask")' the Qualcomm Falkor/Kryo errata 1003 is
> no long applied.
>
> The result of not applying errata 1003 is that MSM8996 runs into various
> RCU stalls and fails to boot most of the times.
>
> Give 1003 a "type" to ensure they are not filtered out in
> update_cpu_capabilities().
>
> Fixes: cce360b54ce6 ("arm64: capabilities: Filter the entries based on a given mask")
> Cc: stable@vger.kernel.org
> Reported-by: Mark Brown <broonie@kernel.org>
> Suggested-by: Will Deacon <will@kernel.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - s/ARM64_CPUCAP_SCOPE_LOCAL_CPU/ARM64_CPUCAP_LOCAL_CPU_ERRATUM/
> - Dropped 1009 "fix" as it already had a type from ERRATA_MIDR_RANGE_LIST()
>
> arch/arm64/kernel/cpu_errata.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index df9465120e2f..3facd5ca52ed 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -780,6 +780,7 @@ const struct arm64_cpu_capabilities arm64_errata[] = {
> {
> .desc = "Qualcomm Technologies Falkor/Kryo erratum 1003",
> .capability = ARM64_WORKAROUND_QCOM_FALKOR_E1003,
> + .type = ARM64_CPUCAP_LOCAL_CPU_ERRATUM,
> .matches = cpucap_multi_entry_cap_matches,
> .match_list = qcom_erratum_1003_list,
> },
> --
> 2.23.0
Thanks, I'll pick this up as a fix.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: cpufeature: Enable Qualcomm Falkor/Kryo errata 1003
2019-10-29 17:39 ` Will Deacon
@ 2019-10-29 17:41 ` Bjorn Andersson
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2019-10-29 17:41 UTC (permalink / raw)
To: Will Deacon
Cc: Catalin Marinas, Suzuki K Poulose, linux-arm-kernel,
linux-kernel, linux-arm-msm, stable, Mark Brown
On Tue 29 Oct 10:39 PDT 2019, Will Deacon wrote:
> On Tue, Oct 29, 2019 at 10:15:39AM -0700, Bjorn Andersson wrote:
> > With the introduction of 'cce360b54ce6 ("arm64: capabilities: Filter the
> > entries based on a given mask")' the Qualcomm Falkor/Kryo errata 1003 is
> > no long applied.
> >
> > The result of not applying errata 1003 is that MSM8996 runs into various
> > RCU stalls and fails to boot most of the times.
> >
> > Give 1003 a "type" to ensure they are not filtered out in
> > update_cpu_capabilities().
> >
> > Fixes: cce360b54ce6 ("arm64: capabilities: Filter the entries based on a given mask")
> > Cc: stable@vger.kernel.org
> > Reported-by: Mark Brown <broonie@kernel.org>
> > Suggested-by: Will Deacon <will@kernel.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >
> > Changes since v1:
> > - s/ARM64_CPUCAP_SCOPE_LOCAL_CPU/ARM64_CPUCAP_LOCAL_CPU_ERRATUM/
> > - Dropped 1009 "fix" as it already had a type from ERRATA_MIDR_RANGE_LIST()
> >
> > arch/arm64/kernel/cpu_errata.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> > index df9465120e2f..3facd5ca52ed 100644
> > --- a/arch/arm64/kernel/cpu_errata.c
> > +++ b/arch/arm64/kernel/cpu_errata.c
> > @@ -780,6 +780,7 @@ const struct arm64_cpu_capabilities arm64_errata[] = {
> > {
> > .desc = "Qualcomm Technologies Falkor/Kryo erratum 1003",
> > .capability = ARM64_WORKAROUND_QCOM_FALKOR_E1003,
> > + .type = ARM64_CPUCAP_LOCAL_CPU_ERRATUM,
> > .matches = cpucap_multi_entry_cap_matches,
> > .match_list = qcom_erratum_1003_list,
> > },
> > --
> > 2.23.0
>
> Thanks, I'll pick this up as a fix.
>
Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 17:15 [PATCH v2] arm64: cpufeature: Enable Qualcomm Falkor/Kryo errata 1003 Bjorn Andersson
2019-10-29 17:39 ` Will Deacon
2019-10-29 17:41 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).