* [PATCH v1] ALSA: usb-audio: sound: usb: usb true/false for bool return type
@ 2019-10-29 17:52 Saurav Girepunje
2019-10-30 7:47 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2019-10-29 17:52 UTC (permalink / raw)
To: perex, tiwai, allison, rfontana, saurav.girepunje, tglx, gregkh,
alsa-devel, linux-kernel
Cc: saurav.girepunje
Use true/false for bool type return in uac_clock_source_is_valid().
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
Changes in v1:
- Update the patch subject suggested by Takashi Iwai <tiwai@suse.de>
- Drop "!!" but keep the ternary operator in last return
statement so that function will return always true/false.
sound/usb/clock.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/usb/clock.c b/sound/usb/clock.c
index 72e9bdf76115..8d5538063598 100644
--- a/sound/usb/clock.c
+++ b/sound/usb/clock.c
@@ -167,21 +167,21 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip,
snd_usb_find_clock_source_v3(chip->ctrl_intf, source_id);
if (!cs_desc)
- return 0;
+ return false;
bmControls = le32_to_cpu(cs_desc->bmControls);
} else { /* UAC_VERSION_1/2 */
struct uac_clock_source_descriptor *cs_desc =
snd_usb_find_clock_source(chip->ctrl_intf, source_id);
if (!cs_desc)
- return 0;
+ return false;
bmControls = cs_desc->bmControls;
}
/* If a clock source can't tell us whether it's valid, we assume it is */
if (!uac_v2v3_control_is_readable(bmControls,
UAC2_CS_CONTROL_CLOCK_VALID))
- return 1;
+ return true;
err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_CUR,
USB_TYPE_CLASS | USB_RECIP_INTERFACE | USB_DIR_IN,
@@ -193,10 +193,10 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip,
dev_warn(&dev->dev,
"%s(): cannot get clock validity for id %d\n",
__func__, source_id);
- return 0;
+ return false;
}
- return !!data;
+ return data ? true : false;
}
static int __uac_clock_find_source(struct snd_usb_audio *chip, int entity_id,
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ALSA: usb-audio: sound: usb: usb true/false for bool return type
2019-10-29 17:52 [PATCH v1] ALSA: usb-audio: sound: usb: usb true/false for bool return type Saurav Girepunje
@ 2019-10-30 7:47 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2019-10-30 7:47 UTC (permalink / raw)
To: Saurav Girepunje
Cc: perex, tiwai, allison, rfontana, tglx, gregkh, alsa-devel,
linux-kernel, saurav.girepunje
On Tue, 29 Oct 2019 18:52:00 +0100,
Saurav Girepunje wrote:
>
> Use true/false for bool type return in uac_clock_source_is_valid().
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>
> Changes in v1:
>
> - Update the patch subject suggested by Takashi Iwai <tiwai@suse.de>
>
> - Drop "!!" but keep the ternary operator in last return
> statement so that function will return always true/false.
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-30 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 17:52 [PATCH v1] ALSA: usb-audio: sound: usb: usb true/false for bool return type Saurav Girepunje
2019-10-30 7:47 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).