Re: [PATCH 04/12] ia64: Replace cpu_down with freeze_secondary_cpus

From: kbuild test robot <lkp@intel.com>
To: Qais Yousef <qais.yousef@arm.com>
Cc: kbuild-all@lists.01.org, Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Qais Yousef <qais.yousef@arm.com>,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/12] ia64: Replace cpu_down with freeze_secondary_cpus
Date: Sat, 2 Nov 2019 12:59:26 +0800	[thread overview]
Message-ID: <201911021233.EpSBhYHc%lkp@intel.com> (raw)
In-Reply-To: <20191030153837.18107-5-qais.yousef@arm.com>

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

Hi Qais,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc5 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Qais-Yousef/arm64-hibernate-c-create-a-new-function-to-handle-cpu_up-sleep_cpu/20191102-053138
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 0dbe6cb8f7e05bc9611602ef45980a6c57b245a3
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/ia64/kernel/process.c: In function 'machine_shutdown':
>> arch/ia64/kernel/process.c:651:2: error: implicit declaration of function 'freeze_secondary_cpus'; did you mean 'suspend_enable_secondary_cpus'? [-Werror=implicit-function-declaration]
     freeze_secondary_cpus(smp_processor_id());
     ^~~~~~~~~~~~~~~~~~~~~
     suspend_enable_secondary_cpus
   cc1: some warnings being treated as errors

vim +651 arch/ia64/kernel/process.c

   646	
   647	void machine_shutdown(void)
   648	{
   649	#ifdef CONFIG_HOTPLUG_CPU
   650		/* TODO: Can we use disable_nonboot_cpus()? */
 > 651		freeze_secondary_cpus(smp_processor_id());
   652	#endif
   653	#ifdef CONFIG_KEXEC
   654		kexec_disable_iosapic();
   655	#endif
   656	}
   657	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54922 bytes --]