[PATCH V2 1/1] net: ethernet: stmmac: drop unused variable in stm32mp1_set_mode()

[PATCH V2 1/1] net: ethernet: stmmac: drop unused variable in stm32mp1_set_mode()

[Christophe Roullier]

Building with W=1 (cf.scripts/Makefile.extrawarn) outputs:
warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Drop the unused 'ret' variable.

Signed-off-by: Christophe Roullier <christophe.roullier@st.com>

---
V2: update commit message with Marc Gonzalez recommendation
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
index 4ef041bdf6a1..595af2ec89fb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
@@ -175,7 +175,7 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
 {
 	struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
 	u32 reg = dwmac->mode_reg;
-	int val, ret;
+	int val;
 
 	switch (plat_dat->interface) {
 	case PHY_INTERFACE_MODE_MII:
@@ -211,8 +211,8 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
 	}
 
 	/* Need to update PMCCLRR (clear register) */
-	ret = regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
-			   dwmac->ops->syscfg_eth_mask);
+	regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
+		     dwmac->ops->syscfg_eth_mask);
 
 	/* Update PMCSETR (set register) */
 	return regmap_update_bits(dwmac->regmap, reg,
-- 
2.17.1

Re: [PATCH V2 1/1] net: ethernet: stmmac: drop unused variable in stm32mp1_set_mode()

[David Miller]

From: Christophe Roullier <christophe.roullier@st.com>
Date: Mon, 4 Nov 2019 11:51:00 +0100

> Building with W=1 (cf.scripts/Makefile.extrawarn) outputs:
> warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> 
> Drop the unused 'ret' variable.
> 
> Signed-off-by: Christophe Roullier <christophe.roullier@st.com>

Applied to net-next.