* [PATCH v2 0/2] STMFX pinctrl definition updates
@ 2019-11-04 10:55 Amelie Delaunay
2019-11-04 10:55 ` [PATCH v2 1/2] ARM: dts: stm32: remove OV5640 pinctrl definition on stm32mp157c-ev1 Amelie Delaunay
2019-11-04 10:55 ` [PATCH v2 2/2] ARM: dts: stm32: change joystick " Amelie Delaunay
0 siblings, 2 replies; 3+ messages in thread
From: Amelie Delaunay @ 2019-11-04 10:55 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring, Mark Rutland
Cc: linux-stm32, linux-arm-kernel, devicetree, linux-kernel, Amelie Delaunay
Since a502b343ebd0 ("pinctrl: stmfx: update pinconf settings"), pin
configuration has been fixed in STMFX pinctrl driver. Moreover, gpiolib now
fully handles "push-pull" configuration.
This series cleans up stm32mp157c-ev1 stmfx ov5640 pins use and fixes stmfx
joystick pins use otherwise joystick doesn't work.
Amelie Delaunay (2):
ARM: dts: stm32: remove OV5640 pinctrl definition on stm32mp157c-ev1
ARM: dts: stm32: change joystick pinctrl definition on stm32mp157c-ev1
arch/arm/boot/dts/stm32mp157c-ev1.dts | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] ARM: dts: stm32: remove OV5640 pinctrl definition on stm32mp157c-ev1
2019-11-04 10:55 [PATCH v2 0/2] STMFX pinctrl definition updates Amelie Delaunay
@ 2019-11-04 10:55 ` Amelie Delaunay
2019-11-04 10:55 ` [PATCH v2 2/2] ARM: dts: stm32: change joystick " Amelie Delaunay
1 sibling, 0 replies; 3+ messages in thread
From: Amelie Delaunay @ 2019-11-04 10:55 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring, Mark Rutland
Cc: linux-stm32, linux-arm-kernel, devicetree, linux-kernel, Amelie Delaunay
"push-pull" configuration is now fully handled by the gpiolib and the
STMFX pinctrl driver. There is no longer need to declare a pinctrl group
to only configure "push-pull" setting for the line. It is done directly by
the gpiolib.
Fixes: a502b343ebd0 ("pinctrl: stmfx: update pinconf settings")
Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
arch/arm/boot/dts/stm32mp157c-ev1.dts | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index 2baae5f25e2c..3f7fcba3a516 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -182,14 +182,12 @@
ov5640: camera@3c {
compatible = "ovti,ov5640";
- pinctrl-names = "default";
- pinctrl-0 = <&ov5640_pins>;
reg = <0x3c>;
clocks = <&clk_ext_camera>;
clock-names = "xclk";
DOVDD-supply = <&v2v8>;
- powerdown-gpios = <&stmfx_pinctrl 18 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&stmfx_pinctrl 19 GPIO_ACTIVE_LOW>;
+ powerdown-gpios = <&stmfx_pinctrl 18 (GPIO_ACTIVE_HIGH | GPIO_PUSH_PULL)>;
+ reset-gpios = <&stmfx_pinctrl 19 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
rotation = <180>;
status = "okay";
@@ -225,12 +223,6 @@
drive-push-pull;
bias-pull-down;
};
-
- ov5640_pins: camera {
- pins = "agpio2", "agpio3"; /* stmfx pins 18 & 19 */
- drive-push-pull;
- output-low;
- };
};
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] ARM: dts: stm32: change joystick pinctrl definition on stm32mp157c-ev1
2019-11-04 10:55 [PATCH v2 0/2] STMFX pinctrl definition updates Amelie Delaunay
2019-11-04 10:55 ` [PATCH v2 1/2] ARM: dts: stm32: remove OV5640 pinctrl definition on stm32mp157c-ev1 Amelie Delaunay
@ 2019-11-04 10:55 ` Amelie Delaunay
1 sibling, 0 replies; 3+ messages in thread
From: Amelie Delaunay @ 2019-11-04 10:55 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Rob Herring, Mark Rutland
Cc: linux-stm32, linux-arm-kernel, devicetree, linux-kernel, Amelie Delaunay
Pins used for joystick are all configured as input. "push-pull" is not a
valid setting for an input pin.
Fixes: a502b343ebd0 ("pinctrl: stmfx: update pinconf settings")
Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
arch/arm/boot/dts/stm32mp157c-ev1.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index 3f7fcba3a516..3789312c8539 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -220,7 +220,6 @@
joystick_pins: joystick {
pins = "gpio0", "gpio1", "gpio2", "gpio3", "gpio4";
- drive-push-pull;
bias-pull-down;
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-04 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 10:55 [PATCH v2 0/2] STMFX pinctrl definition updates Amelie Delaunay
2019-11-04 10:55 ` [PATCH v2 1/2] ARM: dts: stm32: remove OV5640 pinctrl definition on stm32mp157c-ev1 Amelie Delaunay
2019-11-04 10:55 ` [PATCH v2 2/2] ARM: dts: stm32: change joystick " Amelie Delaunay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).