linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/3] v4l2-ctl: Support query V4L2_CTRL_TYPE_AREA controls
@ 2019-11-04 13:09 Ricardo Ribalda Delgado
  2019-11-04 13:09 ` [PATCH v2 2/3] v4l2-ctl: Support getting " Ricardo Ribalda Delgado
  2019-11-04 13:10 ` [PATCH v2 3/3] v4l2-ctl: Support setting " Ricardo Ribalda Delgado
  0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2019-11-04 13:09 UTC (permalink / raw)
  To: Hans Verkuil, linux-media, linux-kernel; +Cc: Ricardo Ribalda Delgado

Tested with vivid:

$ v4l2-ctl -l | grep area
                           area 0x0098f90b (area)   : flags=has-payload

Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
 utils/v4l2-ctl/v4l2-ctl-common.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp
index 651917e7..b1c12b35 100644
--- a/utils/v4l2-ctl/v4l2-ctl-common.cpp
+++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp
@@ -458,6 +458,9 @@ static void print_qctrl(int fd, struct v4l2_query_ext_ctrl *queryctrl,
 				queryctrl->minimum, queryctrl->maximum,
 				queryctrl->step, queryctrl->default_value);
 		break;
+	case V4L2_CTRL_TYPE_AREA:
+		printf("%31s %#8.8x (area)   :", s.c_str(), queryctrl->id);
+		break;
 	default:
 		printf("%31s %#8.8x (unknown): type=%x",
 				s.c_str(), queryctrl->id, queryctrl->type);
-- 
2.24.0.rc1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 2/3] v4l2-ctl: Support getting  V4L2_CTRL_TYPE_AREA controls
  2019-11-04 13:09 [PATCH v2 1/3] v4l2-ctl: Support query V4L2_CTRL_TYPE_AREA controls Ricardo Ribalda Delgado
@ 2019-11-04 13:09 ` Ricardo Ribalda Delgado
  2019-11-04 13:10 ` [PATCH v2 3/3] v4l2-ctl: Support setting " Ricardo Ribalda Delgado
  1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2019-11-04 13:09 UTC (permalink / raw)
  To: Hans Verkuil, linux-media, linux-kernel; +Cc: Ricardo Ribalda Delgado

Tested with vivid:

v4l2-ctl -C area -d /dev/video1
area: 51966x727837

Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
 utils/v4l2-ctl/v4l2-ctl-common.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp
index b1c12b35..95339561 100644
--- a/utils/v4l2-ctl/v4l2-ctl-common.cpp
+++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp
@@ -1150,6 +1150,11 @@ void common_get(cv4l_fd &_fd)
 							printf("%s: '%s'\n", name.c_str(),
 								safename(ctrl.string).c_str());
 							break;
+						case V4L2_CTRL_TYPE_AREA:
+							printf("%s: %dx%d\n", name.c_str(),
+							       ctrl.p_area->width,
+							       ctrl.p_area->height);
+							break;
 						default:
 							fprintf(stderr, "%s: unsupported payload type\n",
 									qc.name);
-- 
2.24.0.rc1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 3/3] v4l2-ctl: Support setting V4L2_CTRL_TYPE_AREA controls
  2019-11-04 13:09 [PATCH v2 1/3] v4l2-ctl: Support query V4L2_CTRL_TYPE_AREA controls Ricardo Ribalda Delgado
  2019-11-04 13:09 ` [PATCH v2 2/3] v4l2-ctl: Support getting " Ricardo Ribalda Delgado
@ 2019-11-04 13:10 ` Ricardo Ribalda Delgado
  1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2019-11-04 13:10 UTC (permalink / raw)
  To: Hans Verkuil, linux-media, linux-kernel; +Cc: Ricardo Ribalda Delgado

$ v4l2-ctl  -d /dev/video1  -c area=123123x233

Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
 utils/v4l2-ctl/v4l2-ctl-common.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp
index 95339561..e079c274 100644
--- a/utils/v4l2-ctl/v4l2-ctl-common.cpp
+++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp
@@ -973,6 +973,10 @@ void common_set(cv4l_fd &_fd)
 					strncpy(ctrl.string, iter->second.c_str(), qc.maximum);
 					ctrl.string[qc.maximum] = 0;
 					break;
+				case V4L2_CTRL_TYPE_AREA:
+					sscanf(iter->second.c_str(), "%ux%u",
+					       &ctrl.p_area->width, &ctrl.p_area->height);
+					break;
 				default:
 					fprintf(stderr, "%s: unsupported payload type\n",
 							qc.name);
-- 
2.24.0.rc1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-04 13:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 13:09 [PATCH v2 1/3] v4l2-ctl: Support query V4L2_CTRL_TYPE_AREA controls Ricardo Ribalda Delgado
2019-11-04 13:09 ` [PATCH v2 2/3] v4l2-ctl: Support getting " Ricardo Ribalda Delgado
2019-11-04 13:10 ` [PATCH v2 3/3] v4l2-ctl: Support setting " Ricardo Ribalda Delgado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).