* Re: drivers/cpufreq/brcmstb-avs-cpufreq.c:449: bad test ?
[not found] <DB7PR08MB38017C35D2B5E025804338129C660@DB7PR08MB3801.eurprd08.prod.outlook.com>
@ 2019-11-05 6:47 ` Viresh Kumar
0 siblings, 0 replies; only message in thread
From: Viresh Kumar @ 2019-11-05 6:47 UTC (permalink / raw)
To: David Binderman
Cc: mmayer, bcm-kernel-feedback-list, rjw, f.fainelli, linux-pm,
linux-arm-kernel, Linux Kernel Mailing List
On 28-10-19, 15:18, David Binderman wrote:
> Hello there,
>
> drivers/cpufreq/brcmstb-avs-cpufreq.c:449:61: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
>
> Source code is
>
> return (magic == AVS_FIRMWARE_MAGIC) && ((rc != -ENOTSUPP) ||
> (rc != -EINVAL));
>
> Maybe better code:
>
> return (magic == AVS_FIRMWARE_MAGIC) && (rc != -ENOTSUPP) &&
> (rc != -EINVAL);
Right. Care to send a proper patch for this ?
--
viresh
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-05 6:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <DB7PR08MB38017C35D2B5E025804338129C660@DB7PR08MB3801.eurprd08.prod.outlook.com>
2019-11-05 6:47 ` drivers/cpufreq/brcmstb-avs-cpufreq.c:449: bad test ? Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).